Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve page error messages #4314

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

donniean
Copy link
Contributor

@donniean donniean commented Sep 25, 2024

What type of PR is this?

What this PR does / why we need it:

When an error occurs in Node.js, the page may only display "Not Found".

The error prompt has now been improved.

before

CleanShot 2024-09-25 at 15 04 13

after

CleanShot 2024-09-25 at 15 25 46

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 25, 2024
@donniean
Copy link
Contributor Author

/cc @wansir

@ks-ci-bot ks-ci-bot requested a review from wansir September 25, 2024 07:14
@donniean
Copy link
Contributor Author

/cc @yazhouio

@ks-ci-bot ks-ci-bot requested a review from yazhouio September 25, 2024 07:14
@donniean
Copy link
Contributor Author

/hold

@donniean
Copy link
Contributor Author

/unhold

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donniean, yazhouio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yazhouio
Copy link
Member

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 3cc52ce70af17e501b1660b44536f0a38e8e692b

@ks-ci-bot ks-ci-bot merged commit 75df2ae into kubesphere:master Sep 25, 2024
5 checks passed
@donniean donniean deleted the dev branch September 26, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants