Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update volcano addon to 1.9 #19159

Merged
merged 2 commits into from
Jul 2, 2024
Merged

feat: update volcano addon to 1.9 #19159

merged 2 commits into from
Jul 2, 2024

Conversation

ComradeProgrammer
Copy link
Member

@ComradeProgrammer ComradeProgrammer commented Jun 29, 2024 •
edited
Loading

substitution of #18965
CLOSE #18965

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 29, 2024
@ComradeProgrammer
Copy link
Member Author

ComradeProgrammer commented Jun 30, 2024 •
edited
Loading

ok-to-test
I can do this right?

@ComradeProgrammer
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 30, 2024
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@spowelljr
Copy link
Member

/retest-this-please

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 19159) |
+-------------------+----------+---------------------+
| ⚠️  minikube start | 47.4s    | 73.3s ⚠️             |
| enable ingress    | 25.6s    | 25.1s               |
+-------------------+----------+---------------------+

Times for minikube start: 48.3s 48.3s 45.4s 45.8s 49.2s
Times for minikube (PR 19159) start: 51.7s 163.3s 48.7s 49.9s 52.7s

Times for minikube ingress: 26.9s 22.4s 24.4s 28.5s 25.5s
Times for minikube (PR 19159) ingress: 24.0s 24.9s 24.4s 24.9s 27.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19159) |
+----------------+----------+---------------------+
| minikube start | 23.7s    | 23.0s               |
| enable ingress | 22.3s    | 22.0s               |
+----------------+----------+---------------------+

Times for minikube start: 20.9s 23.5s 25.0s 24.4s 24.8s
Times for minikube (PR 19159) start: 23.9s 20.8s 24.3s 24.6s 21.5s

Times for minikube (PR 19159) ingress: 22.3s 21.8s 21.8s 22.3s 21.8s
Times for minikube ingress: 25.8s 21.8s 20.3s 21.8s 21.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19159) |
+----------------+----------+---------------------+
| minikube start | 21.2s    | 21.2s               |
| enable ingress | 31.9s    | 33.1s               |
+----------------+----------+---------------------+

Times for minikube start: 19.8s 20.4s 22.6s 23.2s 19.8s
Times for minikube (PR 19159) start: 21.4s 19.5s 21.0s 23.7s 20.7s

Times for minikube ingress: 32.3s 31.8s 31.8s 31.8s 31.8s
Times for minikube (PR 19159) ingress: 31.8s 47.8s 32.3s 32.8s 20.8s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_crio TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 0.68 (chart)
KVM_Linux_crio TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 2.07 (chart)
QEMU_macOS TestAddons/Setup (gopogh) 8.77 (chart)
QEMU_macOS TestFunctional/parallel/CertSync (gopogh) 8.77 (chart)
QEMU_macOS TestFunctional/parallel/CpCmd (gopogh) 8.77 (chart)
QEMU_macOS TestFunctional/parallel/FileSync (gopogh) 8.77 (chart)
QEMU_macOS TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 8.77 (chart)
QEMU_macOS TestFunctional/parallel/SSHCmd (gopogh) 8.77 (chart)
QEMU_macOS TestFunctional/parallel/UpdateContextCmd/no_changes (gopogh) 8.77 (chart)
QEMU_macOS TestFunctional/parallel/UpdateContextCmd/no_clusters (gopogh) 8.77 (chart)
QEMU_macOS TestFunctional/parallel/UpdateContextCmd/no_minikube_cluster (gopogh) 8.77 (chart)
QEMU_macOS TestFunctional/parallel/Version/components (gopogh) 8.77 (chart)
QEMU_macOS TestFunctional/serial/CacheCmd/cache/cache_reload (gopogh) 8.77 (chart)
QEMU_macOS TestFunctional/serial/CacheCmd/cache/verify_cache_inside_node (gopogh) 8.77 (chart)
QEMU_macOS TestFunctional/serial/KubeContext (gopogh) 8.77 (chart)
QEMU_macOS TestFunctional/serial/KubectlGetPods (gopogh) 8.77 (chart)
QEMU_macOS TestFunctional/serial/LogsCmd (gopogh) 8.77 (chart)
QEMU_macOS TestFunctional/serial/LogsFileCmd (gopogh) 8.77 (chart)
QEMU_macOS TestFunctional/serial/MinikubeKubectlCmd (gopogh) 8.77 (chart)
QEMU_macOS TestFunctional/serial/MinikubeKubectlCmdDirectly (gopogh) 8.77 (chart)
QEMU_macOS TestFunctional/serial/SoftStart (gopogh) 8.77 (chart)
QEMU_macOS TestFunctional/serial/StartWithProxy (gopogh) 8.77 (chart)
QEMU_macOS TestErrorSpam/setup (gopogh) 10.53 (chart)
QEMU_macOS TestFunctional/parallel/DashboardCmd (gopogh) 10.53 (chart)
QEMU_macOS TestFunctional/parallel/DockerEnv/bash (gopogh) 10.53 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 10.53 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 10.53 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 10.53 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 10.53 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 10.53 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr mentioned this pull request Jul 2, 2024
Closed
spowelljr
spowelljr approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@spowelljr spowelljr merged commit 32841e9 into kubernetes:master Jul 2, 2024
34 of 47 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ComradeProgrammer, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spowelljr spowelljr spowelljr approved these changes

@medyagh medyagh Awaiting requested review from medyagh

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ComradeProgrammer @minikube-pr-bot @spowelljr @k8s-ci-robot @minikube-bot