Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon Volcano: Update volcano images from v1.7.0 to v1.9.0 #18965

Closed

Conversation

minikube-bot
Copy link
Collaborator

The Volcano project made a new release

This PR was auto-generated by make update-volcano-version using update-volcano-version.yml CI Workflow.

@minikube-bot minikube-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 27, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @minikube-bot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: minikube-bot
Once this PR has been reviewed and has the lgtm label, please assign afbjorklund for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@spowelljr
Copy link
Member

cc @ComradeProgrammer

@spowelljr spowelljr added the do-not-merge/failing-test Indicates that a PR should not merge because it has a failing test label May 29, 2024
@minikube-bot minikube-bot force-pushed the auto_bump_volcano_version branch from d29d40e to 47d925b Compare June 3, 2024 10:02
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-bot minikube-bot force-pushed the auto_bump_volcano_version branch from 47d925b to 471ac83 Compare June 10, 2024 10:01
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@ComradeProgrammer
Copy link
Member

ComradeProgrammer commented Jun 16, 2024

How to edit this pr?

I found the problem locally and fixed it. But can I directly edit this pr?

@minikube-bot minikube-bot force-pushed the auto_bump_volcano_version branch from 471ac83 to 9923252 Compare June 17, 2024 10:02
@minikube-pr-bot

This comment has been minimized.

@medyagh
Copy link
Member

medyagh commented Jun 17, 2024

@ComradeProgrammer plz feel free to create a new PR based on this

@minikube-pr-bot

This comment has been minimized.

@minikube-bot minikube-bot force-pushed the auto_bump_volcano_version branch from 9923252 to 5d2749e Compare June 24, 2024 10:02
@minikube-pr-bot

This comment has been minimized.

@spowelljr
Copy link
Member

spowelljr commented Jun 24, 2024

How to edit this pr?

I found the problem locally and fixed it. But can I directly edit this pr?

If you have the GitHub CLI installed you can do gh pr checkout 18965, and then make your commit and git push and it will update the PR.

@minikube-pr-bot

This comment has been minimized.

@minikube-bot minikube-bot force-pushed the auto_bump_volcano_version branch from 5d2749e to 6733416 Compare July 1, 2024 10:01
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18965) |
+----------------+----------+---------------------+
| minikube start | 48.5s    | 48.8s               |
| enable ingress | 25.8s    | 23.6s               |
+----------------+----------+---------------------+

Times for minikube ingress: 28.0s 24.9s 24.4s 23.5s 28.4s
Times for minikube (PR 18965) ingress: 23.5s 23.9s 23.9s 23.9s 22.9s

Times for minikube start: 48.3s 49.9s 46.7s 49.2s 48.6s
Times for minikube (PR 18965) start: 47.9s 46.0s 49.7s 50.5s 49.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18965) |
+----------------+----------+---------------------+
| minikube start | 22.2s    | 22.5s               |
| enable ingress | 21.1s    | 22.0s               |
+----------------+----------+---------------------+

Times for minikube start: 22.0s 21.5s 25.5s 21.1s 21.0s
Times for minikube (PR 18965) start: 20.9s 22.3s 22.6s 21.5s 25.3s

Times for minikube ingress: 21.3s 20.3s 21.3s 21.3s 21.3s
Times for minikube (PR 18965) ingress: 21.8s 21.8s 21.8s 21.8s 22.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18965) |
+----------------+----------+---------------------+
| minikube start | 21.9s    | 21.3s               |
| enable ingress | 32.9s    | 33.3s               |
+----------------+----------+---------------------+

Times for minikube (PR 18965) start: 20.0s 20.0s 20.4s 23.0s 23.0s
Times for minikube start: 20.7s 22.8s 20.1s 23.3s 22.7s

Times for minikube ingress: 48.3s 31.8s 20.8s 31.8s 31.8s
Times for minikube (PR 18965) ingress: 32.3s 33.3s 48.3s 31.8s 20.8s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestAddons/parallel/Volcano (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestAddons/parallel/Volcano (gopogh) 0.00 (chart)
Docker_Linux TestAddons/parallel/Volcano (gopogh) 0.00 (chart)
Docker_macOS TestAddons/parallel/Volcano (gopogh) 0.00 (chart)
Hyperkit_macOS TestAddons/parallel/Volcano (gopogh) 0.00 (chart)
KVM_Linux TestAddons/parallel/Volcano (gopogh) 0.00 (chart)
none_Linux TestAddons/parallel/Volcano (gopogh) 0.00 (chart)
QEMU_macOS TestAddons/parallel/Volcano (gopogh) 0.00 (chart)
KVM_Linux_containerd TestAddons/parallel/Volcano (gopogh) 1.37 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/Volcano (gopogh) 2.05 (chart)
KVM_Linux_crio TestAddons/Setup (gopogh) 19.01 (chart)

To see the flake rates of all tests by environment, click here.

@spowelljr
Copy link
Member

Done in #19159

@spowelljr spowelljr closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/failing-test Indicates that a PR should not merge because it has a failing test ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants