Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO: Update Buildroot from 2023.02.9 to 2024.02.7 #18433

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Mar 18, 2024

Also updates the Go version the ISO uses from 1.21.6 to 1.23.2

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from medyagh and prezha March 18, 2024 16:32
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2024
@spowelljr spowelljr changed the title ISO: Update Buildroot from 2023.02.9 to 2024.02 ISO: Update Buildroot from 2023.02.9 to 2024.02.2 May 15, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2024
@medyagh medyagh changed the title ISO: Update Buildroot from 2023.02.9 to 2024.02.2 WIP: ISO: Update Buildroot from 2023.02.9 to 2024.02.2 Jun 17, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2024
@spowelljr spowelljr changed the title WIP: ISO: Update Buildroot from 2023.02.9 to 2024.02.2 WIP: ISO: Update Buildroot from 2023.02.9 to 2024.02.4 Jul 22, 2024
@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 21, 2024
@spowelljr spowelljr changed the title WIP: ISO: Update Buildroot from 2023.02.9 to 2024.02.4 WIP: ISO: Update Buildroot from 2023.02.9 to 2024.02.7 Nov 1, 2024
@spowelljr spowelljr removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 1, 2024
@spowelljr
Copy link
Member Author

ok-to-build-iso

@kubernetes kubernetes deleted a comment from k8s-triage-robot Nov 2, 2024
@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 2, 2024
@spowelljr spowelljr changed the title WIP: ISO: Update Buildroot from 2023.02.9 to 2024.02.7 ISO: Update Buildroot from 2023.02.9 to 2024.02.7 Nov 2, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2024
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18433) |
+----------------+----------+---------------------+
| minikube start | 48.2s    | 50.9s               |
| enable ingress | 15.0s    | 15.9s               |
+----------------+----------+---------------------+

Times for minikube start: 47.1s 50.0s 47.0s 47.6s 49.3s
Times for minikube (PR 18433) start: 48.9s 51.0s 52.3s 51.1s 51.2s

Times for minikube ingress: 14.9s 15.4s 15.9s 14.5s 14.4s
Times for minikube (PR 18433) ingress: 15.5s 14.5s 18.5s 14.9s 16.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18433) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 22.1s               |
| enable ingress | 12.7s    | 13.0s               |
+----------------+----------+---------------------+

Times for minikube start: 21.1s 23.3s 20.2s 24.3s 21.2s
Times for minikube (PR 18433) start: 24.0s 20.2s 21.3s 20.8s 24.1s

Times for minikube ingress: 12.3s 12.3s 12.8s 12.3s 13.9s
Times for minikube (PR 18433) ingress: 13.3s 12.8s 12.8s 13.8s 12.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18433) |
+----------------+----------+---------------------+
| minikube start | 20.2s    | 21.1s               |
| enable ingress | 37.5s    | 39.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 39.8s 40.3s 39.3s 28.8s 39.3s
Times for minikube (PR 18433) ingress: 38.9s 38.8s 38.8s 39.3s 40.3s

Times for minikube start: 19.5s 19.9s 22.4s 19.5s 19.9s
Times for minikube (PR 18433) start: 19.8s 23.1s 22.8s 19.6s 20.1s

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
KVM_Linux (1 failed) TestFunctional/parallel/NonActiveRuntimeDisabled(gopogh) 0.00% (chart)
Docker_Linux_docker_arm64 (1 failed) TestFunctional/parallel/MountCmd/specific-port(gopogh) 0.00% (chart)
KVM_Linux_containerd (1 failed) TestFunctional/parallel/NonActiveRuntimeDisabled(gopogh) 0.00% (chart)

Besides the following environments also have failed tests:

  • Docker_Linux_crio: 2 failed (gopogh)

  • Docker_Linux_containerd_arm64: 1 failed (gopogh)

  • KVM_Linux_crio: 146 failed (gopogh)

  • Docker_Cloud_Shell: 3 failed (gopogh)

  • Docker_Linux_crio_arm64: 2 failed (gopogh)

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants