Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO: Bump Go version from 1.21.6 to 1.23.2 #19892

Closed
wants to merge 1 commit into from

Conversation

spowelljr
Copy link
Member

Our Go version in the ISO is too old and preventing us from updating deps (#19891):
go: go.mod requires go >= 1.22.0 (running go 1.21.6)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2024
@spowelljr
Copy link
Member Author

ok-to-build-iso

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2024
@spowelljr
Copy link
Member Author

ISO is failing to build due to Go 1.19.11 coming from somewhere

16:11:27 >>> host-go 1.23.2 Configuring
16:11:27 >>> host-go 1.23.2 Building
16:11:27 cd /home/jenkins/go/src/k8s.io/minikube/out/buildroot/output-aarch64/build/host-go-1.23.2/src && GO111MODULE=off GOCACHE=/home/jenkins/go/src/k8s.io/minikube/out/buildroot/output-aarch64/host/share/host-go-cache GOROOT_BOOTSTRAP=/home/jenkins/go/src/k8s.io/minikube/out/buildroot/output-aarch64/host/lib/go-1.19.11 GOROOT_FINAL=/home/jenkins/go/src/k8s.io/minikube/out/buildroot/output-aarch64/host/lib/go GOROOT="/home/jenkins/go/src/k8s.io/minikube/out/buildroot/output-aarch64/build/host-go-1.23.2" GOBIN="/home/jenkins/go/src/k8s.io/minikube/out/buildroot/output-aarch64/build/host-go-1.23.2/bin" GOOS=linux CC=/usr/bin/gcc CXX=/usr/bin/g++ CGO_ENABLED=1 CC_FOR_TARGET="/home/jenkins/go/src/k8s.io/minikube/out/buildroot/output-aarch64/host/bin/aarch64-minikube-linux-gnu-gcc" CXX_FOR_TARGET="/home/jenkins/go/src/k8s.io/minikube/out/buildroot/output-aarch64/host/bin/aarch64-minikube-linux-gnu-g++" GOOS="linux" GOARCH=arm64   GO_ASSUME_CROSSCOMPILING=1 ./make.bash 
16:11:28 Building Go cmd/dist using /home/jenkins/go/src/k8s.io/minikube/out/buildroot/output-aarch64/host/lib/go-1.19.11. (go1.19.11 linux/amd64)
16:11:28 found packages main (build.go) and building_Go_requires_Go_1_20_6_or_later (notgo120.go) in /home/jenkins/go/src/k8s.io/minikube/out/buildroot/output-aarch64/build/host-go-1.23.2/src/cmd/dist
16:11:28 make[2]: *** [package/pkg-generic.mk:283: /home/jenkins/go/src/k8s.io/minikube/out/buildroot/output-aarch64/build/host-go-1.23.2/.stamp_built] Error 1

@spowelljr
Copy link
Member Author

go-bootstrap-stage3 was added to LTS Buildroot in 2024.02.7, we will need to update to at least that version to bump the go version to 1.22 or beyond.

@spowelljr
Copy link
Member Author

Rolling this change into #18433

@spowelljr spowelljr closed this Nov 1, 2024
@spowelljr spowelljr deleted the buildISOGoVersion branch November 1, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants