Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore scheduler processing #6235

Merged

Conversation

atwamahmoud
Copy link
Contributor

@atwamahmoud atwamahmoud commented Oct 31, 2023

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

  • Moves FilterOutAndSplitExpendables calls to a new PodListProcessor
  • Moves clearTpuRequests calls to a new PodListProcessor
  • Use pods which are not marked by scheduler yet (schedulerUnprocessed) as Unschedulable pods since schedulable pods will be filtered by the current PodListProcessor effectively making CA not wait for scheduler

Does this PR introduce a user-facing change?

Adds new flag "bypassed-scheduler-names"  with default empty value to maintain original behaviour.
If flag is set to non-empty list, CA will not wait for schedulers (listed in the flag value) to mark pods as unschedulable and will evaluate non processed pods.
Furthermore, if bypassed schedulers are non-empty CA will not wait for pods to reach a certain age to scale-up, effectively ignoring `unschedulablePodTimeBuffer`

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2023
cluster-autoscaler/main.go Outdated Show resolved Hide resolved
cluster-autoscaler/core/static_autoscaler.go Show resolved Hide resolved
cluster-autoscaler/utils/kubernetes/listers.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 8, 2023
cluster-autoscaler/config/autoscaling_options.go Outdated Show resolved Hide resolved
cluster-autoscaler/core/static_autoscaler_test.go Outdated Show resolved Hide resolved
cluster-autoscaler/main.go Outdated Show resolved Hide resolved
cluster-autoscaler/utils/kubernetes/listers.go Outdated Show resolved Hide resolved
@atwamahmoud atwamahmoud requested a review from x13n November 20, 2023 15:06
cluster-autoscaler/config/autoscaling_options.go Outdated Show resolved Hide resolved
cluster-autoscaler/utils/kubernetes/listers.go Outdated Show resolved Hide resolved
cluster-autoscaler/core/static_autoscaler_test.go Outdated Show resolved Hide resolved
cluster-autoscaler/core/static_autoscaler_test.go Outdated Show resolved Hide resolved
cluster-autoscaler/core/static_autoscaler_test.go Outdated Show resolved Hide resolved
@x13n
Copy link
Member

x13n commented Nov 21, 2023

Thanks! Can you squash the commits? I mean, not necessarily to a single commit, since there is a lot going on here, but 20 commits seem a bit much.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atwamahmoud, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2023
@atwamahmoud atwamahmoud force-pushed the ignore-scheduler-processing branch from f9d8a35 to 5115f12 Compare November 22, 2023 11:21
@x13n
Copy link
Member

x13n commented Nov 22, 2023

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 39245a5 into kubernetes:master Nov 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants