-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provides flags for users to expose and set UnschedulablePodTime… #6231
Provides flags for users to expose and set UnschedulablePodTime… #6231
Conversation
…Buffer, UnschedulablePodWithGpuTimeBuffer
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aiden-von The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Github Action has not been working for more than 30 minutes and is in a Action required state. |
/test ? |
@aiden-von: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@aiden-von: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @vadasambar, can you review this PR? I need this feature 🙇 thanks! |
/assign vadasambar |
/ok-to-test |
@x13n we might need your approval to run the test workflow 🙏 |
Hello, @x13n If I understand correctly, #6235 seems to ignore kube-scheduler processing. I think we need to check whether the person who created this issue wants to reduce buffer time or ignore scheduling, but I think #6235 could be an alternative. If you think the issue(#6087) is resolved by the PR(#6235), I wouldn't mind closing this PR. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'm guessing the answer is "yes", will close this PR due to inactivity. Please reopen if anything changes. /close |
@x13n: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Provides flags for users to expose and set UnschedulablePodTimeBuffer, UnschedulablePodWithGpuTimeBuffer.
Which issue(s) this PR fixes:
Fixes #6087
Does this PR introduce a user-facing change?