Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provides flags for users to expose and set UnschedulablePodTime… #6231

Conversation

aiden-von
Copy link

What type of PR is this?

/kind feature

What this PR does / why we need it:

Provides flags for users to expose and set UnschedulablePodTimeBuffer, UnschedulablePodWithGpuTimeBuffer.

Which issue(s) this PR fixes:

Fixes #6087

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 29, 2023
@k8s-ci-robot k8s-ci-robot requested a review from feiskyer October 29, 2023 11:37
@k8s-ci-robot k8s-ci-robot requested a review from x13n October 29, 2023 11:37
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aiden-von
Once this PR has been reviewed and has the lgtm label, please assign bigdarkclown for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 29, 2023
@aiden-von aiden-von changed the title feat: Provides flags for users to expose and set UnschedulablePodTime… Provides flags for users to expose and set UnschedulablePodTime… Oct 29, 2023
@aiden-von
Copy link
Author

aiden-von commented Oct 29, 2023

Github Action has not been working for more than 30 minutes and is in a Action required state.
Can someone help me?

@aiden-von
Copy link
Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@aiden-von: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@aiden-von: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@injae-kim
Copy link

Hi @vadasambar, can you review this PR? I need this feature 🙇 thanks!

@vadasambar
Copy link
Member

/assign vadasambar

@vadasambar
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 2, 2023
@vadasambar
Copy link
Member

@x13n we might need your approval to run the test workflow 🙏

@x13n
Copy link
Member

x13n commented Nov 3, 2023

Actually I'd instead wait for #6235 which goes even further - bypassing not just the buffer time, but even kube-scheduler processing. Would this be an acceptable fix for #6087?

@aiden-von
Copy link
Author

aiden-von commented Nov 4, 2023

Hello, @x13n

If I understand correctly, #6235 seems to ignore kube-scheduler processing.

I think we need to check whether the person who created this issue wants to reduce buffer time or ignore scheduling, but I think #6235 could be an alternative.

If you think the issue(#6087) is resolved by the PR(#6235), I wouldn't mind closing this PR.
Thank you.

@x13n
Copy link
Member

x13n commented Nov 6, 2023

@maxpain - does that sound like a good fix for #6087 you created?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 23, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@x13n
Copy link
Member

x13n commented Nov 24, 2023

I'm guessing the answer is "yes", will close this PR due to inactivity. Please reopen if anything changes.

/close

@k8s-ci-robot
Copy link
Contributor

@x13n: Closed this PR.

In response to this:

I'm guessing the answer is "yes", will close this PR due to inactivity. Please reopen if anything changes.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unschedulablePodWithGpuTimeBuffer configuration
5 participants