-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove zw0610 from approvers #2343
Conversation
Pull Request Test Coverage Report for Build 12132136084Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of your great contributions @zw0610. I hope you will return to the project in the future!
@kubeflow/wg-training-leads What do you think about adding the emeritus_approvers
section for Training Operator ?
I know that other Kubernetes projects, like Kueue, does this: https://github.com/kubernetes-sigs/kueue/blob/main/OWNERS#L16.
SGTM! @zw0610 Could you please help add the emeritus_approvers in the file? |
Signed-off-by: Wang Zhang <[email protected]>
done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contributions so far!
Yes we should add emeritus_approvers. |
/lgtm Thanks for your contribution! 🎉 👍 |
SGTM |
@zw0610 Thank you for all your contributions! I hope you are well on your next journey! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tenzen-y Do you mean mention it somewhere here: https://www.kubeflow.org/docs/about/membership/#inactive-members ? |
I would indicate https://www.kubeflow.org/docs/about/membership/#approver |
I think, we should be ready to merge it. |
I am removing myself from training-operator approvers.
Thanks for @kubeflow community and all your helps! @gaocegege @Jeffwan