Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Emeritus Approvers Info to the Kubeflow Membership #3941

Merged

Conversation

andreyvelich
Copy link
Member

We discussed that we want to add the section about emeritus approvers to the Kubeflow membership doc: kubeflow/training-operator#2343 (comment)

I took the info from the Kubernetes docs: https://www.kubernetes.dev/docs/guide/owners/#emeritus

/assign @kubeflow/wg-training-leads @anishasthana @kubeflow/kubeflow-steering-committee @akgraner


```yaml
emeritus_approvers:
- david # 2018-05-02
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this start or end time?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@anishasthana anishasthana Dec 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for the end-term
I think it's inconsistently applied. I've seen it in some projects but not all.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably remove this info then. People can track it in commit history anyways.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done.

@andreyvelich
Copy link
Member Author

/assign @varodrig @hbelmiro

@andreyvelich andreyvelich force-pushed the add-emeritus-approvers branch from 91888e2 to afe930b Compare December 10, 2024 16:36
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member Author

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 19c92e2 into kubeflow:master Dec 10, 2024
6 checks passed
@andreyvelich andreyvelich deleted the add-emeritus-approvers branch December 11, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants