-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Emeritus Approvers Info to the Kubeflow Membership #3941
Add Emeritus Approvers Info to the Kubeflow Membership #3941
Conversation
|
||
```yaml | ||
emeritus_approvers: | ||
- david # 2018-05-02 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this start or end time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, it is end term.
However, it doesn't look like Kubernetes adds it:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's for the end-term
I think it's inconsistently applied. I've seen it in some projects but not all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably remove this info then. People can track it in commit history anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, done.
Signed-off-by: Andrey Velichkevich <[email protected]>
91888e2
to
afe930b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We discussed that we want to add the section about emeritus approvers to the Kubeflow membership doc: kubeflow/training-operator#2343 (comment)
I took the info from the Kubernetes docs: https://www.kubernetes.dev/docs/guide/owners/#emeritus
/assign @kubeflow/wg-training-leads @anishasthana @kubeflow/kubeflow-steering-committee @akgraner