Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel image upload cli #630

Merged
merged 11 commits into from
Nov 21, 2024
Merged

Kernel image upload cli #630

merged 11 commits into from
Nov 21, 2024

Conversation

ivntsng
Copy link
Contributor

@ivntsng ivntsng commented Nov 19, 2024

What does this PR do?

  • Added support for users to upload kernel images their listing via CLI
  • Display file size for kernel images in listing view
  • Add download confirmation modal with file details
Screenshot 2024-11-20 at 9 43 20 AM Screenshot 2024-11-20 at 9 43 30 AM

@ivntsng ivntsng self-assigned this Nov 19, 2024
@ivntsng ivntsng marked this pull request as ready for review November 20, 2024 06:17
Copy link
Contributor

@Winston-Hsiao Winston-Hsiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the one frontend consideration for user experience/cost saving.

frontend/src/components/listing/ListingImageGallery.tsx Outdated Show resolved Hide resolved
frontend/src/hooks/api.tsx Outdated Show resolved Hide resolved
store/app/routers/artifacts.py Outdated Show resolved Hide resolved
store/app/routers/artifacts.py Outdated Show resolved Hide resolved
store/app/model.py Outdated Show resolved Hide resolved
store/app/routers/artifacts.py Outdated Show resolved Hide resolved
@ivntsng ivntsng merged commit 655e4a9 into master Nov 21, 2024
1 check passed
@ivntsng ivntsng deleted the kernel-image-upload-cli branch November 21, 2024 01:28
ivntsng added a commit that referenced this pull request Nov 21, 2024
* Support for uploading kernel images via CLI

* Frontend failure & model changes

* Uploading kernel images via CLI

* Kernel-Images upload instructions

* Kernel image handling in listing view

* Ensure kernel images are downloaded with the correct format

* Added file size and download confirmation for kernel files

* Improve UI for kernel image

* Refactor S3 operations and additional changes

* Removed f-string from logger

* Added checksum for uploading kernel image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants