Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve order api endpoints #623

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Improve order api endpoints #623

merged 4 commits into from
Nov 18, 2024

Conversation

Winston-Hsiao
Copy link
Contributor

@Winston-Hsiao Winston-Hsiao commented Nov 18, 2024 •
edited
Loading

What does this PR do?

  1. Removed all instances of typing.List and typing.Dict and use standard list and dict
  2. Standardized naming convention for Order endpoints.

@Winston-Hsiao Winston-Hsiao self-assigned this Nov 18, 2024
@Winston-Hsiao Winston-Hsiao changed the title Improve order api endpoint Improve order api endpoints Nov 18, 2024
codekansas
codekansas requested changes Nov 18, 2024
View reviewed changes
store/app/model.py Outdated Show resolved Hide resolved
store/app/routers/orders.py Outdated Show resolved Hide resolved
store/app/routers/orders.py Outdated Show resolved Hide resolved
codekansas
codekansas approved these changes Nov 18, 2024
View reviewed changes
store/app/routers/orders.py Show resolved Hide resolved
@Winston-Hsiao Winston-Hsiao merged commit a93b46c into master Nov 18, 2024
1 check passed
@Winston-Hsiao Winston-Hsiao deleted the improve-order-api-endpoint branch November 18, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codekansas codekansas codekansas approved these changes

@ivntsng ivntsng Awaiting requested review from ivntsng

Assignees

@Winston-Hsiao Winston-Hsiao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Winston-Hsiao @codekansas