Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing border for GDPR banner, updated image artifacts, small … #609

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Added missing border for GDPR banner, updated image artifacts, small … #609

merged 2 commits into from
Nov 15, 2024

Conversation

ivntsng
Copy link
Contributor

@ivntsng ivntsng commented Nov 15, 2024

…updates to Navbar and sidebar

What does this PR do?

  • Added image-first sorting logic to ensure images are displayed correctly
  • Fix broken image displays when non-image files (e.g., .tgz) are first in artifacts
  • Handle non-image artifacts properly
  • Listings always show an image if available
  • Non-image files don't appear as broken images
  • Small UI changes for NavBar and Sidebar
  • Added a missing border for GDPR

@ivntsng ivntsng self-assigned this Nov 15, 2024
@ivntsng ivntsng linked an issue Nov 15, 2024 that may be closed by this pull request
Additional UI updates #608
Closed
@ivntsng ivntsng merged commit 24c98d4 into master Nov 15, 2024
1 check passed
@ivntsng ivntsng deleted the 608-additional-ui-updates branch November 15, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codekansas codekansas Awaiting requested review from codekansas

@budzianowski budzianowski Awaiting requested review from budzianowski

@jingxiangmo jingxiangmo Awaiting requested review from jingxiangmo

@Winston-Hsiao Winston-Hsiao Awaiting requested review from Winston-Hsiao

@vrtnis vrtnis Awaiting requested review from vrtnis

Assignees

@ivntsng ivntsng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional UI updates
1 participant
@ivntsng