Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listings for sale improvements #585

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

Winston-Hsiao
Copy link
Contributor

@Winston-Hsiao Winston-Hsiao commented Nov 11, 2024

What does this PR do?

  1. Better default auth flow (require user to be logged in)
  2. Improves clarity/UI of robot for sale listings.
  3. Decrement listing inventory_quantity by quantity after successful order is placed
  4. Affirm as payment option ONLY for orders over $50 (otherwise it errors out when trying to start checkout session since Affirm not allowed on less than $50)
  5. Quantity 1 fix checkout session (dynamic line item generation)
  6. Quantity 0 shows out of stock and does not allow check out session creation
  7. Other small misc UI improvements

What issues does this PR fix or reference?
Closes #575

Lighter backdrop for Stripe Onboarding (better text/bg color contrast ratio)

Screenshot 2024-11-11 at 3 29 19 PM

Robot listing (sell)

Screenshot 2024-11-11 at 3 37 02 PM

After placing a successful order via checkout

Screenshot 2024-11-11 at 6 09 35 PM

@Winston-Hsiao Winston-Hsiao self-assigned this Nov 11, 2024
@Winston-Hsiao Winston-Hsiao linked an issue Nov 11, 2024 that may be closed by this pull request
3 tasks
@Winston-Hsiao Winston-Hsiao changed the title Listings for sale UI improvements Listings for sale improvements Nov 11, 2024
@Winston-Hsiao Winston-Hsiao merged commit 3aee0ef into master Nov 11, 2024
1 check passed
@Winston-Hsiao Winston-Hsiao deleted the 575-refine-listing-sell-stripe-connect branch November 11, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine Listing Sell Stripe Connect
1 participant