Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stripe Connect Listing Payments #568

Merged
merged 7 commits into from
Nov 10, 2024
Merged

Stripe Connect Listing Payments #568

merged 7 commits into from
Nov 10, 2024

Conversation

Winston-Hsiao
Copy link
Contributor

@Winston-Hsiao Winston-Hsiao commented Nov 10, 2024 •
edited
Loading

What does this PR do?

  1. Splits bot/listing creation flow into two paths (share and sell), both use original listing model, users need to have completed stripe connect onboarding to post a robot for sale
  2. Listing pages include a button that links to checkout session to purchase the robot
  3. Pre-order and reservation for listings
  4. Can convert to normal listing and subtract deposit amount previously paid (still need to look into validating this)

What issues does this PR fix or reference?
Closes #536

If this PR changes the UI, include a screenshot below.

Sell option is available if the user has completed seller onboarding

Screenshot 2024-11-10 at 12 32 07 PM

If Robot listing is for sale display payment info and checkout button that opens check out session

Screenshot 2024-11-10 at 12 19 42 PM

Checkout session after clicking Purchase Now

Screenshot 2024-11-10 at 12 46 16 PM

@Winston-Hsiao Winston-Hsiao self-assigned this Nov 10, 2024
@Winston-Hsiao Winston-Hsiao changed the title Stripe connect listing payments Stripe Connect Listing Payments Nov 10, 2024
codekansas
codekansas approved these changes Nov 10, 2024
View reviewed changes
Copy link
Member

@codekansas codekansas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!!

@codekansas codekansas merged commit 20043e6 into master Nov 10, 2024
1 check passed
@codekansas codekansas deleted the stripe-connect-listing-payments branch November 10, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codekansas codekansas codekansas approved these changes

@ivntsng ivntsng Awaiting requested review from ivntsng

@budzianowski budzianowski Awaiting requested review from budzianowski

@vrtnis vrtnis Awaiting requested review from vrtnis

Assignees

@Winston-Hsiao Winston-Hsiao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Finish Stripe integration
2 participants
@Winston-Hsiao @codekansas