Content manager & featured listings #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivntsng
requested review from
codekansas,
Winston-Hsiao,
budzianowski and
vrtnis
codekansas
reviewed
Nov 4, 2024
codekansas
approved these changes
Nov 5, 2024
codekansas
requested changes
Nov 5, 2024
Comment on lines
+187
to
+189
| handleItemClick( | ||
| `/item/${listing.username}/${listing.slug || listing.id}`, | ||
| ) |
There was a problem hiding this comment.
at some point we should move to having typed urls instead of string matching, since it is pretty error prone. like a route map
type RouteConfig = {
path: AppRoute;
component: React.FC;
};
const routes: RouteConfig[] = [
{ path: AppRoutes.Home, component: Home },
{ path: AppRoutes.Profile, component: Profile },
{ path: AppRoutes.Settings, component: Settings },
];
// Route rendering
import { Route, Routes } from "react-router-dom";
const AppRouter: React.FC = () => (
<Routes>
{routes.map(({ path, component: Component }) => (
<Route key={path} path={path} element={<Component />} />
))}
</Routes>
);
codekansas
requested changes
Nov 5, 2024
Comment on lines
+58
to
+66
| if (response.error) { | ||
| addErrorAlert(response.error); | ||
| } else { | ||
| const newFeaturedState = !isFeatured; | ||
| setIsFeatured(newFeaturedState); | ||
| addAlert( | ||
| `Listing ${newFeaturedState ? "featured" : "unfeatured"} successfully`, | ||
| "success", | ||
| ); |
There was a problem hiding this comment.
this is such a common pattern, i feel like there must be a way to do this better - should make an issue for this
|
mstm |
codekansas
approved these changes
Nov 6, 2024
|
ref: #526 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added content manager role and featured listings
If this PR changes the UI, include a screenshot below.
No featured listings and featured button on post.
Content manager role
