Feature/urdf to mjcf #309
Merged
Feature/urdf to mjcf #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codekansas
reviewed
Aug 22, 2024
store/app/crud/urdf.py
Outdated
| if mesh_names: | ||
| raise BadArtifactError(f"Mesh files uploaded were not referenced: {mesh_names}") | ||
|
|
||
| logger.info("refs", mesh_references) |
There was a problem hiding this comment.
we dont want redundancy tho
store/app/routers/urdf.py
Outdated
| @@ -89,10 +89,11 @@ async def set_urdf( | |||
|
|
|||
| # Gets the compression type from the file content type and filename. | |||
| compression_type = get_compression_type(file.content_type, file.filename) | |||
| if compression_type not in ("tgz", "zip"): | |||
|
|
|||
| if compression_type not in ("tgz", "zip", "tar.gz"): | |||
There was a problem hiding this comment.
compression_type is a python string literal, tar.gz shouldn't be an option (it gets mapped to tgz compression type)
store/app/utils/convert.py
Outdated
| from store.app.utils.formats import mjcf | ||
|
|
||
|
|
||
| def contains_urdf_or_mjcf(folder_path: Path) -> str: |
There was a problem hiding this comment.
this is gonna seem even more neurotic but you can do this instead. the reason is that the type checker will then be able to detect string typos
Suggested change
| def contains_urdf_or_mjcf(folder_path: Path) -> str: | |
| from typing import MeshType | |
| MeshType = Literal["urdf", "mjcf"] | |
| def contains_urdf_or_mjcf(folder_path: Path) -> MeshType: |
Comment on lines
+479
to
+481
| # HACK | ||
| # mujoco has a hard time reading meshes | ||
| _copy_stl_files(self.output_dir / "meshes", self.output_dir) |
There was a problem hiding this comment.
we should probably do this correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This should be a short, one-line description.
What issues does this PR fix or reference?
If relevant, please include a reference to the issue here.
If this PR changes the UI, include a screenshot below.
Otherwise, feel free to delete this section.