Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify RequireAuthentication and AuthenticationModal #268

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Unify RequireAuthentication and AuthenticationModal #268

merged 1 commit into from
Aug 7, 2024

Conversation

chennisden
Copy link
Contributor

Resolves #267

image

@chennisden
Copy link
Contributor Author

rebased onto master

@chennisden
Unify RequireAuthentication and AuthenticationModal
377b46a 
- Delete StaticBackground
	It wasn't doing anything anyway.
- Replace LogInModal with AuthBlock
	Create a div and use the `fixed inset-0 ...` classes from
	LogInModal to replicate the same "the modal is covering the
	screen" effect.
- Delete RequireAuthentication.tsx, which exports the LogInModal.
	This is because the file is no longer used.
@chennisden chennisden enabled auto-merge (squash) August 7, 2024 16:52
@chennisden chennisden merged commit caf3f31 into master Aug 7, 2024
1 check passed
@chennisden chennisden deleted the gated-consistent branch August 7, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codekansas codekansas codekansas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gated login modal is inconsistent
2 participants
@chennisden @codekansas