Fix TODO for setting up openapi-fetch #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codekansas
requested changes
Jul 31, 2024
frontend/src/hooks/api.tsx
Outdated
Comment on lines
9
to
18
| const authMiddleware: Middleware = { | ||
| async onRequest({ request }) { | ||
| const accessToken = localStorage.getItem("AUTH"); | ||
| if (!accessToken) { | ||
| throw new Error("No access token found"); | ||
| } | ||
|
|
||
| request.headers.set("Authorization", `Bearer ${accessToken}`); | ||
| return request; | ||
| }, |
There was a problem hiding this comment.
ah interesting, i didn't realize this code path still existed, seems like we should merge with auth.tsx
frontend/src/hooks/ApiCalls.tsx
Outdated
Comment on lines
17
to
18
| fd.append("file", file); | ||
| fd.append("metadata", JSON.stringify(request)); |
| // console.error("Error uploading file:", error); | ||
| // } | ||
| const { error } = await APICalls.upload(selectedFile, { | ||
| artifact_type: "image", |
| // }); | ||
| const { response, error } = await APICalls.upload(compressedFile, { | ||
| artifact_type: "image", | ||
| listing_id: "5", |
There was a problem hiding this comment.
should add listing_id to props i believe? like the component should be used to upload an image for an associated listing
codekansas
reviewed
Jul 31, 2024
frontend/src/hooks/auth.tsx
Outdated
Comment on lines
47
to
57
| const authMiddleware: Middleware = { | ||
| async onRequest({ request }) { | ||
| const accessToken = localStorage.getItem("AUTH"); | ||
| if (!accessToken) { | ||
| throw new Error("No access token found"); | ||
| } | ||
|
|
||
| request.headers.set("Authorization", `Bearer ${accessToken}`); | ||
| return request; | ||
| }, | ||
| }; |
codekansas
reviewed
Jul 31, 2024
frontend/src/hooks/auth.tsx
Outdated
Comment on lines
50
to
52
| if (!accessToken) { | ||
| throw new Error("No access token found"); | ||
| } |
There was a problem hiding this comment.
this is incorrect, no? what if the user is not logged in - they should still be able to make api calls to the public endpoint?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes @codekansas comments TODO.
however listing_id is hardcoded. I am not sure if we are going to use ImageUpload /UDRFUpload components.