Skip to content

Commit

Permalink
Adjust footer to not cover content (#29)
Browse files Browse the repository at this point in the history
In particular, when the screen isn't big enough and a vertical scrollbar
is necessary. We did this by introducing a bottom margin on the content
  • Loading branch information
chennisden authored May 31, 2024
1 parent d54c14b commit 7989aa9
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 8 deletions.
4 changes: 4 additions & 0 deletions frontend/src/App.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
div.content {
margin-top: 16px;
margin-bottom: 56px;
}
16 changes: 8 additions & 8 deletions frontend/src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const App = () => {
<BrowserRouter>
<TopNavbar />

<Container className="mt-3">
<Container className="content">
<Routes>
<Route path="/" element={<Home />} />
<Route path="/robots/" element={<Robots />} />
Expand All @@ -28,14 +28,14 @@ const App = () => {
<Route path="/404" element={<NotFound />} />
<Route path="*" element={<NotFoundRedirect />} />
</Routes>

<footer className="fixed-bottom">
{/* Solid background */}
<div className="text-center bg-body-tertiary p-2">
<a href="mailto:[email protected]">[email protected]</a>
</div>
</footer>
</Container>

<footer className="fixed-bottom">
{/* Solid background */}
<div className="text-center bg-body-tertiary p-2">
<a href="mailto:[email protected]">[email protected]</a>
</div>
</footer>
</BrowserRouter>
</ThemeProvider>
);
Expand Down

0 comments on commit 7989aa9

Please sign in to comment.