Remove payment intent data for setup mode checkout session (#606)

kscalelabs · Nov 15, 2024 · 69a8316 · 69a8316
1 parent fa13d34
commit 69a8316
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/frontend/src/gen/api.ts b/frontend/src/gen/api.ts
@@ -925,7 +925,7 @@ export interface paths {
         put?: never;
         /**
          * Stripe Webhook
-         * @description Handle direct account webhooks (non-Connect events)
+         * @description Handle direct account webhooks (non-Connect events).
          */
         post: operations["stripe_webhook_stripe_webhook_post"];
         delete?: never;
@@ -945,7 +945,7 @@ export interface paths {
         put?: never;
         /**
          * Stripe Connect Webhook
-         * @description Handle Connect account webhooks
+         * @description Handle Connect account webhooks.
          */
         post: operations["stripe_connect_webhook_stripe_connect_webhook_post"];
         delete?: never;

diff --git a/store/app/routers/stripe.py b/store/app/routers/stripe.py
@@ -447,7 +447,7 @@ async def create_checkout_session(
             }
 
             # Add payment intent data to save the payment method if it's new
-            if not existing_payment_methods:
+            if not existing_payment_methods and listing.inventory_type != "preorder":
                 checkout_params["payment_intent_data"] = {
                     **checkout_params.get("payment_intent_data", {}),
                     "setup_future_usage": "off_session",
@@ -485,6 +485,8 @@ async def create_checkout_session(
                             )
                         }
                     }
+                # Remove payment_intent_data if it exists
+                checkout_params.pop("payment_intent_data", None)
             else:
                 # Regular payment mode
                 if not listing.stripe_price_id and listing.stripe_product_id: