cleanup prints #19
Closed
cleanup prints #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use logging instead of prints
codekansas
reviewed
Dec 8, 2024
examples/test_extract.py
Outdated
| return 1 | ||
|
|
||
| return 0 | ||
| logging.error(f"Error: {e}") |
There was a problem hiding this comment.
oh, i thought i disabled f-strings in logging in pylint... this is not ideal, see here: https://pylint.readthedocs.io/en/stable/user_guide/messages/warning/logging-fstring-interpolation.html
examples/test_extract.py
Outdated
| @@ -38,5 +36,7 @@ def main(args): | |||
| parser.add_argument("-o", "--output-file", type=str, help="Output KRec file path (optional)") | |||
| parser.add_argument("-v", "--verbose", action="store_true", help="Enable verbose output") | |||
|
|
|||
| logging.basicConfig(level=logging.INFO, format="%(asctime)s - %(levelname)s - %(message)s") | |||
There was a problem hiding this comment.
actually, you can add colorlogging as a dependency, it is a small package i wrote to make it easy to configure nice logging: https://pypi.org/project/colorlogging/
codekansas
reviewed
Dec 9, 2024
setup.py
Outdated
| @@ -60,6 +60,7 @@ def run(self) -> None: | |||
| ), | |||
| ], | |||
| setup_requires=["setuptools-rust"], | |||
| install_requires=["colorlogging"], | |||
There was a problem hiding this comment.
put into requirements.txt not here
|
I've merged this branch into combine_mkv_overwrite_by_default so we can ignore this branch going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use logging instead of prints