Suppress ffmpeg output by default and add verbose argument to display it #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hatomist
approved these changes
Dec 4, 2024
codekansas
reviewed
Dec 6, 2024
Comment on lines
+64
to
+67
| print(f"krec_obj: {krec_obj}") | ||
| print(f"krec_obj.header: {krec_obj.header}") | ||
| print(f"num frames: {len(krec_obj)}") | ||
| print(f"succesfully loaded KRec file!") |
There was a problem hiding this comment.
don't use print statements
use logging
There was a problem hiding this comment.
to be fair, not a library code but just an example script
There was a problem hiding this comment.
yes, I did use logging in the library code, for example see here
Line 89 in cdaae80
but if we don't want print statements in the example files, I'm happy to change that as well.
There was a problem hiding this comment.
we should use python logging everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be tested with the example script provided and any krec.mkv file