Krec ts & ffmpeg fix (#4)

* krec-ts

* added ffmpeg null output; gitignore

.gitignore

@@ -24,3 +24,7 @@ out*/
 # Rust
 Cargo.lock
 target/
+
+# Node
+krec-ts/node_modules/
+krec-ts/src/generated/

Cargo.toml

@@ -28,5 +28,5 @@ resolver = "2"
 
 [workspace.package]
 
-version = "0.2.7"
+version = "0.2.8"
 edition = "2021"

krec-ts/package.json

@@ -0,0 +1,23 @@
+{
+  "name": "krec-ts",
+  "version": "1.0.0",
+  "main": "index.js",
+  "scripts": {
+    "test": "echo \"Error: no test specified\" && exit 1",
+    "generate-proto": "pbjs -t static-module -w commonjs -o src/generated/proto.js ../proto/krec.proto && pbts -o src/generated/proto.d.ts src/generated/proto.js"
+  },
+  "keywords": [],
+  "author": "",
+  "license": "ISC",
+  "description": "",
+  "dependencies": {
+    "@types/node": "^18.19.65",
+    "long": "^5.2.3",
+    "protobufjs": "^7.4.0"
+  },
+  "devDependencies": {
+    "@types/long": "^5.0.0",
+    "ts-node": "^10.9.2",
+    "typescript": "^5.8.0"
+  }
+}

krec-ts/src/example.ts

@@ -0,0 +1,40 @@
+import { KRec } from "./krec";
+import { promises as fs } from "fs";
+import { Long } from "protobufjs/minimal";
+
+// Helper function to convert Long timestamp to Date
+function longToDate(timestamp: Long): Date {
+  // Convert nanoseconds to milliseconds
+  const ms = Number(timestamp) / 1_000_000;
+  return new Date(ms);
+}
+
+// Helper function to format Long to number (safe for frame numbers)
+function longToNumber(value: Long): number {
+  return Number(value);
+}
+
+async function main() {
+  const buffer = await fs.readFile("./test.krec");
+
+  const krec = await KRec.load(buffer);
+
+  console.log("Recording UUID:", krec.header.uuid);
+  console.log("Number of frames:", krec.frames.length);
+
+  if (krec.frames.length > 0) {
+    const frame = krec.frames[0];
+    console.log("First frame:", {
+      timestamp: longToDate(frame.videoTimestamp as Long).toISOString(),
+      frameNumber: longToNumber(frame.frameNumber as Long),
+      actuatorStates: frame.actuatorStates?.map(state => ({
+        online: state.online,
+        position: state.position,
+        velocity: state.velocity,
+        torque: state.torque
+      }))
+    });
+  }
+}
+
+main().catch(console.error); 

krec-ts/src/krec.ts

@@ -0,0 +1,67 @@
+import { Reader } from "protobufjs";
+import { krec } from "./generated/proto";
+
+export class KRec {
+  header: krec.proto.IKRecHeader;
+  frames: krec.proto.IKRecFrame[];
+
+  constructor(header: krec.proto.IKRecHeader) {
+    this.header = header;
+    this.frames = [];
+  }
+
+  static async load(buffer: Buffer): Promise<KRec> {
+    let pos = 0;
+
+    // Read header length and decode header
+    if (buffer.length < 4) {
+      throw new Error(`File too short: ${buffer.length} bytes`);
+    }
+
+    const headerLen = buffer.readUInt32LE(0);
+    pos += 4;
+
+    if (pos + headerLen > buffer.length) {
+      throw new Error(
+        `Incomplete header data: need ${headerLen} bytes, have ${buffer.length - pos} bytes`
+      );
+    }
+
+    const header = krec.proto.KRecHeader.decode(
+      Reader.create(buffer.subarray(pos, pos + headerLen))
+    );
+    pos += headerLen;
+
+    const frames: krec.proto.IKRecFrame[] = [];
+
+    // Read frames
+    while (pos + 4 <= buffer.length) {
+      const frameLen = buffer.readUInt32LE(pos);
+      pos += 4;
+
+      if (pos + frameLen > buffer.length) {
+        throw new Error(
+          `Incomplete frame data: at position ${pos}, need ${frameLen} bytes, have ${
+            buffer.length - pos
+          } bytes remaining`
+        );
+      }
+
+      const frame = krec.proto.KRecFrame.decode(
+        Reader.create(buffer.subarray(pos, pos + frameLen))
+      );
+      pos += frameLen;
+      frames.push(frame);
+    }
+
+    if (pos !== buffer.length) {
+      throw new Error(
+        `Trailing data: ${buffer.length - pos} bytes remaining after position ${pos}`
+      );
+    }
+
+    const krecInstance = new KRec(header);
+    krecInstance.frames = frames;
+    return krecInstance;
+  }
+} 

krec-ts/tsconfig.json

@@ -0,0 +1,14 @@
+{
+  "compilerOptions": {
+    "target": "es2018",
+    "module": "commonjs",
+    "strict": true,
+    "esModuleInterop": true,
+    "skipLibCheck": true,
+    "forceConsistentCasingInFileNames": true,
+    "outDir": "./dist",
+    "declaration": true
+  },
+  "include": ["src/**/*"],
+  "exclude": ["node_modules"]
+}

krec/bindings/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "maturin"
 
 [project]
 name = "bindings"
-version = "0.1.4"
+version = "0.1.5"
 description = "Python bindings for KRec"
 authors = [{ name = "Denys Bezmenov", email = "[email protected]" }]
 requires-python = ">=3.7"

src/ffmpeg.rs

@@ -83,7 +83,15 @@ pub fn combine_with_video(
 
 pub fn extract_from_video(video_path: &str, output_path: &str) -> Result<(), FFmpegError> {
     let status = std::process::Command::new("ffmpeg")
-        .args(["-dump_attachment:t:0", output_path, "-i", video_path])
+        .args([
+            "-dump_attachment:t:0",
+            output_path,
+            "-i",
+            video_path,
+            "-f",
+            "null",
+            "/dev/null",
+        ])
         .status()
         .map_err(|e| FFmpegError::FFmpeg(e.to_string()))?;