-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secrets consistency for the chart. Bugfixing. #1
Commits on Jun 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 130410c - Browse repository at this point
Copy the full SHA 130410cView commit details -
Merge pull request grafana#2162 from grafana/dev
get rid of need for FEATURE_PROMETHEUS_EXPORTER_ENABLED to be present in ci-test.py settings file
Configuration menu - View commit details
-
Copy full SHA for ae6e03d - Browse repository at this point
Copy the full SHA ae6e03dView commit details -
Merge: Release oncall Helm chart 1.2.42 (grafana#2163)
Merge this PR to `main` branch to start another [github actions job](https://github.com/grafana/oncall/blob/dev/.github/workflows/helm_release.yml) that will release the updated version of the chart (version: 1.2.42, appVersion: v1.2.42) into `grafana/helm-charts` helm repository. This PR was created automatically by this [github action](https://github.com/grafana/oncall/blob/dev/.github/workflows/helm_release_pr.yml). Co-authored-by: GitHub Actions <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bd36370 - Browse repository at this point
Copy the full SHA bd36370View commit details -
Configuration menu - View commit details
-
Copy full SHA for 787304f - Browse repository at this point
Copy the full SHA 787304fView commit details
Commits on Jun 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7bfb552 - Browse repository at this point
Copy the full SHA 7bfb552View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06aa122 - Browse repository at this point
Copy the full SHA 06aa122View commit details -
Merge pull request grafana#2235 from grafana/helm-release/1.2.44
Merge: Release oncall Helm chart 1.2.44
Configuration menu - View commit details
-
Copy full SHA for 4b6e80b - Browse repository at this point
Copy the full SHA 4b6e80bView commit details
Commits on Jun 19, 2023
-
Co-authored-by: Michael Derynck <[email protected]> Co-authored-by: Joey Orlando <[email protected]> Co-authored-by: Matias Bordese <[email protected]> Co-authored-by: Rares Mardare <[email protected]> Co-authored-by: Joey Orlando <[email protected]> Co-authored-by: Ildar Iskhakov <[email protected]> Co-authored-by: Ruslan Gainanov <[email protected]> Co-authored-by: Yulia Shanyrova <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5d03580 - Browse repository at this point
Copy the full SHA 5d03580View commit details
Commits on Jun 22, 2023
-
Fix template preview markup (grafana#2304)
# What this PR does ## Which issue(s) this PR fixes ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
Configuration menu - View commit details
-
Copy full SHA for 0a493be - Browse repository at this point
Copy the full SHA 0a493beView commit details -
Added missing chatOpsDisplayName to OSS + some ui tweaks (grafana#2305)
# What this PR does ## Which issue(s) this PR fixes ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
Configuration menu - View commit details
-
Copy full SHA for a339d80 - Browse repository at this point
Copy the full SHA a339d80View commit details -
Grouping templating chatops fix (grafana#2307)
[css fixes, displaying chatops button visibility fix]
Configuration menu - View commit details
-
Copy full SHA for 2cdab7e - Browse repository at this point
Copy the full SHA 2cdab7eView commit details -
Secrets consistency for the chart. Bugfixing.
- Enabling existing secrets for external MySQL and Redis - Tolerate existing secrets for bundled charts. - README.md: secrets handling explained. - Fixed multiple bugs where missing required field was replaced with default instead of failing. - PHONE_NOTIFICATIONS_LIMIT was on the wrong level: it was not set if existingSecret was true. Next are the cosmetic changes. They improve chart consistency, e.g. prevent generation of multiple new lines in certain cases: - Common approach to spaces trimming. This typically allows curly blocks and actual strings indentation and nice `nindent` usage: - Two curly blocks should not trim the same space. I.e. "{{ ... -}} {{- ... }}" shouldn't happen. - Template generates either single line or multiline string. In both cases, no new line appears on both sides of the output string. So we delete unnecessary new lines inside and at the end of string with "trim-to-left" (`{{-` ) and the leading new line using "trim-to-right" (`-}}`). Note that trimming both leading and trailing new line is not always easily possible: Masterminds/sprig#357 Example. ``` {{- define "mytemplate" -}} {{ if someBoolean -}} {{ .Value.some }} {{- else -}} some string {{- end }} {{- end }} ``` - `template` replaced with `include`. It is often recommended to use `include` by default, as it allows pipelining.
Configuration menu - View commit details
-
Copy full SHA for 293352f - Browse repository at this point
Copy the full SHA 293352fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f38755 - Browse repository at this point
Copy the full SHA 6f38755View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2739db0 - Browse repository at this point
Copy the full SHA 2739db0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dfc30c - Browse repository at this point
Copy the full SHA 3dfc30cView commit details
Commits on Jun 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d70a497 - Browse repository at this point
Copy the full SHA d70a497View commit details