Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets consistency for the chart. Bugfixing. #1

Closed
wants to merge 16 commits into from

Commits on Jun 12, 2023

  1. Merge pull request grafana#2158 from grafana/dev

    dev -> main
    joeyorlando authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    130410c View commit details
    Browse the repository at this point in the history
  2. Merge pull request grafana#2162 from grafana/dev

    get rid of need for FEATURE_PROMETHEUS_EXPORTER_ENABLED to be present in ci-test.py settings file
    joeyorlando authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    ae6e03d View commit details
    Browse the repository at this point in the history
  3. Merge: Release oncall Helm chart 1.2.42 (grafana#2163)

    Merge this PR to `main` branch to start another [github actions
    job](https://github.com/grafana/oncall/blob/dev/.github/workflows/helm_release.yml)
    that will release the updated version of the chart (version: 1.2.42,
    appVersion: v1.2.42) into `grafana/helm-charts` helm repository.
    
    This PR was created automatically by this [github
    action](https://github.com/grafana/oncall/blob/dev/.github/workflows/helm_release_pr.yml).
    
    Co-authored-by: GitHub Actions <[email protected]>
    github-actions[bot] and actions-user authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    bd36370 View commit details
    Browse the repository at this point in the history
  4. Merge pull request grafana#2166 from grafana/dev

    Merge dev to main
    mderynck authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    787304f View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Merge pull request grafana#2234 from grafana/dev

    v1.2.44
    matiasb authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    7bfb552 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    06aa122 View commit details
    Browse the repository at this point in the history
  3. Merge pull request grafana#2235 from grafana/helm-release/1.2.44

    Merge: Release oncall Helm chart 1.2.44
    matiasb authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    4b6e80b View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. Dev to main (grafana#2282)

    Co-authored-by: Michael Derynck <[email protected]>
    Co-authored-by: Joey Orlando <[email protected]>
    Co-authored-by: Matias Bordese <[email protected]>
    Co-authored-by: Rares Mardare <[email protected]>
    Co-authored-by: Joey Orlando <[email protected]>
    Co-authored-by: Ildar Iskhakov <[email protected]>
    Co-authored-by: Ruslan Gainanov <[email protected]>
    Co-authored-by: Yulia Shanyrova <[email protected]>
    9 people authored Jun 19, 2023
    Configuration menu
    Copy the full SHA
    5d03580 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Fix template preview markup (grafana#2304)

    # What this PR does
    
    ## Which issue(s) this PR fixes
    
    ## Checklist
    
    - [ ] Unit, integration, and e2e (if applicable) tests updated
    - [ ] Documentation added (or `pr:no public docs` PR label added if not
    required)
    - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
    required)
    iskhakov authored Jun 22, 2023
    Configuration menu
    Copy the full SHA
    0a493be View commit details
    Browse the repository at this point in the history
  2. Added missing chatOpsDisplayName to OSS + some ui tweaks (grafana#2305)

    # What this PR does
    
    ## Which issue(s) this PR fixes
    
    ## Checklist
    
    - [ ] Unit, integration, and e2e (if applicable) tests updated
    - [ ] Documentation added (or `pr:no public docs` PR label added if not
    required)
    - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
    required)
    teodosii authored Jun 22, 2023
    Configuration menu
    Copy the full SHA
    a339d80 View commit details
    Browse the repository at this point in the history
  3. Grouping templating chatops fix (grafana#2307)

    [css fixes, displaying chatops button visibility fix]
    Ukochka authored Jun 22, 2023
    Configuration menu
    Copy the full SHA
    2cdab7e View commit details
    Browse the repository at this point in the history
  4. Secrets consistency for the chart. Bugfixing.

    - Enabling existing secrets for external MySQL and Redis
    - Tolerate existing secrets for bundled charts.
    - README.md: secrets handling explained.
    - Fixed multiple bugs where missing required field was replaced with
      default instead of failing.
    - PHONE_NOTIFICATIONS_LIMIT was on the wrong level: it was not set if
      existingSecret was true.
    
    Next are the cosmetic changes. They improve chart consistency, e.g.
    prevent generation of multiple new lines in certain cases:
    - Common approach to spaces trimming. This typically allows curly blocks
      and actual strings indentation and nice `nindent` usage:
      - Two curly blocks should not trim the same space. I.e.
        "{{ ... -}} {{- ... }}" shouldn't happen.
      - Template generates either single line or multiline string. In both
        cases, no new line appears on both sides of the output string. So we
        delete unnecessary new lines inside and at the end of string with
        "trim-to-left" (`{{-` ) and the leading new line using
        "trim-to-right" (`-}}`).
        Note that trimming both leading and trailing new line is not
        always easily possible:
        Masterminds/sprig#357
    
        Example.
    
        ```
        {{- define "mytemplate" -}}
        {{ if someBoolean -}}
          {{ .Value.some }}
        {{- else -}}
          some string
        {{- end }}
        {{- end }}
        ```
    
    - `template` replaced with `include`. It is often recommended to use
      `include` by default, as it allows pipelining.
    ksa-real committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    293352f View commit details
    Browse the repository at this point in the history
  5. Update CHANGELOG.md

    matiasb authored Jun 22, 2023
    Configuration menu
    Copy the full SHA
    6f38755 View commit details
    Browse the repository at this point in the history
  6. Merge main to dev

    matiasb committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    2739db0 View commit details
    Browse the repository at this point in the history
  7. Update CHANGELOG.md

    matiasb authored Jun 22, 2023
    Configuration menu
    Copy the full SHA
    3dfc30c View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Configuration menu
    Copy the full SHA
    d70a497 View commit details
    Browse the repository at this point in the history