Secrets consistency for the chart. Bugfixing. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev -> main
get rid of need for FEATURE_PROMETHEUS_EXPORTER_ENABLED to be present in ci-test.py settings file
Merge this PR to `main` branch to start another [github actions job](https://github.com/grafana/oncall/blob/dev/.github/workflows/helm_release.yml) that will release the updated version of the chart (version: 1.2.42, appVersion: v1.2.42) into `grafana/helm-charts` helm repository. This PR was created automatically by this [github action](https://github.com/grafana/oncall/blob/dev/.github/workflows/helm_release_pr.yml). Co-authored-by: GitHub Actions <[email protected]>
Merge dev to main
Merge: Release oncall Helm chart 1.2.44
Co-authored-by: Michael Derynck <[email protected]> Co-authored-by: Joey Orlando <[email protected]> Co-authored-by: Matias Bordese <[email protected]> Co-authored-by: Rares Mardare <[email protected]> Co-authored-by: Joey Orlando <[email protected]> Co-authored-by: Ildar Iskhakov <[email protected]> Co-authored-by: Ruslan Gainanov <[email protected]> Co-authored-by: Yulia Shanyrova <[email protected]>
# What this PR does ## Which issue(s) this PR fixes ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
# What this PR does ## Which issue(s) this PR fixes ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
[css fixes, displaying chatops button visibility fix]
ksa-real
force-pushed
the
existing-secrets
branch
2 times, most recently
from
f409dc9
to
55462d7
Compare
- Enabling existing secrets for external MySQL and Redis
- Tolerate existing secrets for bundled charts.
- README.md: secrets handling explained.
- Fixed multiple bugs where missing required field was replaced with
default instead of failing.
- PHONE_NOTIFICATIONS_LIMIT was on the wrong level: it was not set if
existingSecret was true.
Next are the cosmetic changes. They improve chart consistency, e.g.
prevent generation of multiple new lines in certain cases:
- Common approach to spaces trimming. This typically allows curly blocks
and actual strings indentation and nice `nindent` usage:
- Two curly blocks should not trim the same space. I.e.
"{{ ... -}} {{- ... }}" shouldn't happen.
- Template generates either single line or multiline string. In both
cases, no new line appears on both sides of the output string. So we
delete unnecessary new lines inside and at the end of string with
"trim-to-left" (`{{-` ) and the leading new line using
"trim-to-right" (`-}}`).
Note that trimming both leading and trailing new line is not
always easily possible:
Masterminds/sprig#357
Example.
```
{{- define "mytemplate" -}}
{{ if someBoolean -}}
{{ .Value.some }}
{{- else -}}
some string
{{- end }}
{{- end }}
```
- `template` replaced with `include`. It is often recommended to use
`include` by default, as it allows pipelining.
ksa-real
force-pushed
the
existing-secrets
branch
from
55462d7
to
293352f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next are the cosmetic changes. They improve chart consistency, e.g. prevent generation of multiple new lines in certain cases:
Common approach to spaces trimming. This typically allows curly blocks and actual strings indentation and nice
nindentusage:Two curly blocks should not trim the same space. I.e. "{{ ... -}} {{- ... }}" shouldn't happen.
Template generates either single line or multiline string. In both cases, no new line appears on both sides of the output string. So we delete unnecessary new lines inside and at the end of string with "trim-to-left" (
{{-) and the leading new line using "trim-to-right" (-}}). Note that trimming both leading and trailing new line is not always easily possible: Function similar to nindent but ignoring content's initial new line. Masterminds/sprig#357Example.
{{- define "mytemplate" -}} {{ if someBoolean -}} {{ .Value.some }} {{- else -}} some string {{- end }} {{- end }}templatereplaced withinclude. It is often recommended to useincludeby default, as it allows pipelining.What this PR does
Which issue(s) this PR fixes
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)