Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(KFLUXSPRT-794): pass content-gateway token as env var #334

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix(KFLUXSPRT-794): pass content-gateway token as env var #334

merged 1 commit into from
Dec 4, 2024

Conversation

swickersh
Copy link
Contributor

@swickersh swickersh requested a review from a team as a code owner December 4, 2024 19:26
@swickersh swickersh mentioned this pull request Dec 4, 2024
Merged
@swickersh
fix(KFLUXSPRT-794): pass content-gateway token as env var
faf1819 
- Change name of CGW_TOKEN to CGW_PASSWORD
  - This is actually a token, no pw, but the pubtools library expects
    this environment variable name
- No longer pass token with command invocation

Signed-off-by: Scott Wickersham <[email protected]>
@swickersh swickersh force-pushed the cgw-environment-token branch from 3be11bf to faf1819 Compare December 4, 2024 19:29
@swickersh
Copy link
Contributor Author

@scoheb Can you please double check this? Thanks!

@johnbieren
Copy link
Collaborator

/ok-to-test

@johnbieren
Copy link
Collaborator

Slack leads me to believe my /ok-to-test is supposed to make it work. E2E actually does nothing in this repo but I am interested in the data point so I am going to give it a few minutes to see before force merging

@scoheb
Copy link
Contributor

scoheb commented Dec 4, 2024

Slack leads me to believe my /ok-to-test is supposed to make it work. E2E actually does nothing in this repo but I am interested in the data point so I am going to give it a few minutes to see before force merging

why do you think it is E2E holding it up?

@johnbieren
Copy link
Collaborator

Slack leads me to believe my /ok-to-test is supposed to make it work. E2E actually does nothing in this repo but I am interested in the data point so I am going to give it a few minutes to see before force merging

why do you think it is E2E holding it up?

Red Hat Konflux Queued — Pending approval

@johnbieren johnbieren merged commit 50b8874 into konflux-ci:main Dec 4, 2024
3 of 4 checks passed
scoheb added a commit to scoheb/app-interface-deployments that referenced this pull request Dec 4, 2024
@scoheb
fix(KFLUXSPRT-794): update release utils image
cb3dc83 
- pickup konflux-ci/release-service-utils#334

Signed-off-by: Scott Hebert <[email protected]>
scoheb added a commit to scoheb/app-interface-deployments that referenced this pull request Dec 4, 2024
@scoheb
fix(KFLUXSPRT-794): update release utils image
448540a 
- pickup konflux-ci/release-service-utils#334

Signed-off-by: Scott Hebert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbieren johnbieren johnbieren approved these changes

@mmalina mmalina mmalina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swickersh @johnbieren @scoheb @mmalina