fix(KFLUXSPRT-794): pass content-gateway token as env var #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
swickersh
commented
Dec 4, 2024
•
swickersh
commented
- Change name of CGW_TOKEN to CGW_PASSWORD
- This is actually a token, no pw, but the pubtools library expects this environment variable name
- Relevant PR to pubtools: Allow password to be set via environment release-engineering/pubtools-content-gateway#38
- Accompanies this open PR:
- fix(KFLUXSPRT-794): pass content-gateway token as env var konflux-ci/release-service-utils#334
- Change name of CGW_TOKEN to CGW_PASSWORD
- This is actually a token, no pw, but the pubtools library expects
this environment variable name
Signed-off-by: Scott Wickersham <[email protected]>
|
@scoheb Can you please double check this. I don't interact with this workflow usually. Thanks! |
scoheb
approved these changes
Dec 4, 2024
|
Doesn't this depend on konflux-ci/release-service-utils#334? How will this work without the image update? This looks like it may have just broke stage by being merged |
|
I just realized that. I asked @swickersh in Slack. |
|
This is not the first time I see something like this. I would suggest to either open the PR as Draft when it's not ready yet, or create a thread about the missing thing so that it's clear it needs to be addressed first - the same situation is in another PR, so I opened a thread there: https://github.com/konflux-ci/release-service-catalog/pull/724/files#r1871048033 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.