-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make EC strict mode configurable #1630
Conversation
5f0f7d4
to
0b27a85
Compare
This marks the The latter will need changes in the integration-service I guess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. cc @konflux-ci/ec
/ok-ot-test |
I see the value of doing this, just please be wary that if the check is green no one usually digs through the check to see if there are any issues. If setting strict to false, there is a high chance that you won't find out about issues until release time which is usually not a great user experience. Could you update the description of the parameter to provide some sort of warning to future users thinking about setting struct to false? |
/ok-to-test (without typos now 😅) |
0b27a85
to
47cf4d5
Compare
Sure |
47cf4d5
to
34e29f8
Compare
Signed-off-by: Julen Landa Alustiza <[email protected]>
34e29f8
to
93d4775
Compare
/ok-to-test |
Allow modifying
STRICT
. This allows to mark an EC as informative and not gate changes on it.This is useful for us while we iterate to fix all the violations without gating yet the pull requests