Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EC strict mode configurable #1630

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

Zokormazo
Copy link
Contributor

@Zokormazo Zokormazo commented Nov 21, 2024

Allow modifying STRICT. This allows to mark an EC as informative and not gate changes on it.

This is useful for us while we iterate to fix all the violations without gating yet the pull requests

@Zokormazo
Copy link
Contributor Author

Zokormazo commented Nov 21, 2024

This marks the TestIntegrationScenario green despite the violations, but the CI results on gitlab continues being red :(

The latter will need changes in the integration-service I guess

Copy link
Member

@zregvart zregvart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @konflux-ci/ec

@lcarva
Copy link
Contributor

lcarva commented Nov 21, 2024

/ok-ot-test

@lcarva
Copy link
Contributor

lcarva commented Nov 21, 2024

I see the value of doing this, just please be wary that if the check is green no one usually digs through the check to see if there are any issues. If setting strict to false, there is a high chance that you won't find out about issues until release time which is usually not a great user experience.

Could you update the description of the parameter to provide some sort of warning to future users thinking about setting struct to false?

@lcarva
Copy link
Contributor

lcarva commented Nov 21, 2024

/ok-to-test

(without typos now 😅)

@Zokormazo
Copy link
Contributor Author

Could you update the description of the parameter to provide some sort of warning to future users thinking about setting struct to false?

Sure

Signed-off-by: Julen Landa Alustiza <[email protected]>
@zregvart
Copy link
Member

/ok-to-test

@zregvart zregvart enabled auto-merge November 22, 2024 12:57
@zregvart zregvart added this pull request to the merge queue Nov 22, 2024
Merged via the queue into konflux-ci:main with commit aaf5f93 Nov 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants