Skip to content

Commit

Permalink
Make EC strict mode configurable
Browse files Browse the repository at this point in the history
Signed-off-by: Julen Landa Alustiza <[email protected]>
  • Loading branch information
Zokormazo committed Nov 22, 2024
1 parent e2ad769 commit 47cf4d5
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions pipelines/enterprise-contract.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,15 @@ spec:
type: string
description: PipelineRun ID
default: "pr/$(context.pipelineRun.name)"
- name: STRICT
type: string
description: |
A boolean flag that determines whether the result of the test will mark the TaskRun as passing or not.
Swap to false to make the IntegrationTestScenario informative.
This is useful on specific conditions but will always mark the integration test as successful and
humans will tend ignore the test results if they failed. Use with caution.
default: "true"
results:
- name: TEST_OUTPUT
value: "$(tasks.verify.results.TEST_OUTPUT)"
Expand All @@ -83,12 +92,8 @@ spec:
value: "$(params.SNAPSHOT)"
- name: SSL_CERT_DIR
value: "$(params.SSL_CERT_DIR)"
# It's confusing for users to see a passing taskrun that represents a failing EC test.
# For that reason let's have the taskrun fail when there are EC violations. Also, if
# this is set to false (IIUC), it's not possible to have the IntegrationTest gate the
# deploy to the devel environment work, which is what users expect to be able to do.
- name: STRICT
value: "true"
value: "$(params.STRICT)"
- name: PUBLIC_KEY
value: "$(params.PUBLIC_KEY)"
- name: IGNORE_REKOR
Expand Down

0 comments on commit 47cf4d5

Please sign in to comment.