buildah: Add an ADD_CAPABILITIES paramter #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 21, 2024
This corresponds to 'buildah build --cap-add=<value>' One use case is when we want to do nested sandboxing within the build, and need to set up a new mount namespace - in this case we need ADD_CAPABILITIES=SYS_ADMIN. (Since we are running buildah using --isolation=chroot.) Related: #1014
ralphbean
force-pushed
the
pull/1017/head
branch
from
2ebe6b5 to
851a753
Compare
ralphbean
requested review from
stuartwdouglas,
lcarva,
mmorhun,
rcerven and
chmeliik
chmeliik
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
LGTM, just copying a comment from #1017
For this feature, we would need a policy check that disallows the param by default but lets the policy author allowlist some specific capabilities. Is that feasible?
|
I'd like to proceed without that policy check implemented yet - for external schedule pressure reasons. I'll make sure it gets followed up on: https://issues.redhat.com/browse/EC-678 |
|
@ralphbean , do you know if this ever got documented? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #1017.