Add CAP_SYS_ADMIN param to buildah task #1082
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This instructs buildah to use --cap-add=SYS_ADMIN. The capability is not generally safe and should be restricted by both cluster SecurityContextConstraints and supply chain policy for most situations. The param is present for unusual situations where it is required.
|
#1017 does it more generically (though it would need a slightly more complex policy check I suppose). I'd prefer that one if we're ready to go through with this |
|
You're right! I'm going to sponsor getting that one merged and in and I'll make sure to follow up with EC. |
|
I pushed a rebase of it at #1084. |
|
Merging #1084. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This instructs buildah to use --cap-add=SYS_ADMIN.
The should be restricted by both cluster SecurityContextConstraints and supply chain policy for most situations.
The param is present for unusual situations where it is required.