Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass --all when building manifests #1042

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

stuartwdouglas
Copy link
Contributor

@stuartwdouglas stuartwdouglas commented May 28, 2024

This means the task can also take manifest lists as an input, which is useful when dealing with OCI artifacts.

Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why we want this?

@ralphbean
Copy link
Member

Checking the help for buildah manifest add:

      --all                           add all of the list's images if the image is a list

I suppose then that this helps when making an image index of image indices.

And, although I wasn't a part of the development of this, I can imagine what it's for. For parts of the instructlab project, they want to build disk images with #1059, where (I'm guessing) each build task produces an image index, which then needs to be concatenated onto a longer image index here.

@ralphbean ralphbean requested review from chmeliik and mmorhun July 8, 2024 18:05
@ralphbean ralphbean mentioned this pull request Jul 8, 2024
@chmeliik chmeliik added this pull request to the merge queue Jul 9, 2024
Merged via the queue into konflux-ci:main with commit 9707aea Jul 9, 2024
2 checks passed
@ralphbean
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants