bootc build VM task #1133
Merged
bootc build VM task #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can see more of what's happening.
…info so we can look into disabling fsync to improve performance.
…t-entitlment usage
To make it clear what arguments are passed
Optionally, let the user re-tag the source image before building a disk image from it. This is useful if you want to build from an unreleased image, but have the history of the image appear as if it was built from a released pullspec of that same image.
|
I think this is blocked on #1137. |
|
Submitted enterprise-contract/hacks#102 |
mmorhun
approved these changes
Jul 10, 2024
|
Thank you for the review @mmorhun. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a duplicate of #1059. I'm picking that up since stuart is on PTO.
I tried to address @mmorhun's first round of feedback there, here.
I'll close that one so we can focus on this one (although #1042 is still valid).