Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing execution space in mdrange #108

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

yasahi-hpc
Copy link
Collaborator

@yasahi-hpc yasahi-hpc commented Jun 27, 2024

This PR aims at fixing bugs about execution space in MDRange in some internal helpers.
For example, following modifications are made

// Previous, exec_space was missing
range_type range(
    point_type{{0, 0}}, point_type{{len0, len1}}, tile_type{{4, 4}}
    // [TO DO] Choose optimal tile sizes for each device
 );

// After fix
range_type range(
    exec_space, point_type{{0, 0}}, point_type{{len0, len1}},
    tile_type{{4, 4}}  // [TO DO] Choose optimal tile sizes for each device
);

Copy link
Member

@cedricchevalier19 cedricchevalier19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

Arg name deletion can be done as another PR.

common/src/KokkosFFT_Helpers.hpp Outdated Show resolved Hide resolved
common/src/KokkosFFT_Helpers.hpp Outdated Show resolved Hide resolved
common/src/KokkosFFT_transpose.hpp Outdated Show resolved Hide resolved
@yasahi-hpc
Copy link
Collaborator Author

Good catch.

Arg name deletion can be done as another PR.

Thank you for your review. I have modified accordingly.
Arg name deletion may be done in your PR?

@yasahi-hpc yasahi-hpc merged commit 16fb3f6 into kokkos:main Jul 2, 2024
19 checks passed
@yasahi-hpc yasahi-hpc deleted the use-correct-exec-space branch July 2, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants