Cleaning up some warnings and enabling -Werror on CPU CI tests #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedricchevalier19
force-pushed
the
warnings
branch
from
7f6ecb1 to
43f0aeb
Compare
cedricchevalier19
changed the title
|
Thank you for the PR. I will review as soon as possible. Actually, the unused execution space instance is more like a bug, where I made a PR #108 for hotfix. |
yasahi-hpc
requested changes
Jun 27, 2024
common/src/KokkosFFT_transpose.hpp
Outdated
| @@ -290,12 +286,12 @@ void _transpose(const ExecutionSpace& exec_space, InViewType& in, | |||
| }); | |||
| } | |||
|
|
|||
| // FIXME: not used? | |||
There was a problem hiding this comment.
It is at least tested. The Dimension number is used for MDRange rank, but the maximum rank is 6. So I am performing a sequential operation inside parallel region.
|
@cedricchevalier19 Could you please rebase on the current main. |
cedricchevalier19
force-pushed
the
warnings
branch
from
f94d564 to
7f1bbee
Compare
yasahi-hpc
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should improve #106.