Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Upgrade to latest dependencies #15462

Merged
merged 1 commit into from
Aug 14, 2024
Merged

[main] Upgrade to latest dependencies #15462

merged 1 commit into from
Aug 14, 2024

Conversation

knative-automation
Copy link
Contributor

Cron -knative-prow-robot

/cc knative/serving-writers
/assign knative/serving-writers

Produced by: knative-extensions/knobots/actions/update-deps

@knative-prow knative-prow bot requested a review from a team August 12, 2024 13:10
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 12, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.41%. Comparing base (b7026be) to head (f4a9d89).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15462      +/-   ##
==========================================
- Coverage   84.52%   84.41%   -0.12%     
==========================================
  Files         219      219              
  Lines       13608    13608              
==========================================
- Hits        11502    11487      -15     
- Misses       1737     1748      +11     
- Partials      369      373       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member

Interesting K8s added some schema validation

 Creating resource customresourcedefinition/configurations.serving.knative.dev (apiextensions.k8s.io/v1) cluster:
    API server says:
      CustomResourceDefinition.apiextensions.k8s.io "configurations.serving.knative.dev" is invalid: 

  - spec.validation.openAPIV3Schema.properties[spec].properties[template].properties[spec].properties[hostAliases].x-kubernetes-list-map-keys: Invalid value: []string{"ip"}: entries must all be names of item properties

  - spec.validation.openAPIV3Schema.properties[spec].properties[template].properties[spec].properties[containers].items.properties[name].default: Required value: this property is in x-kubernetes-list-map-keys

  - so it must have a default or be a required property

  - spec.validation.openAPIV3Schema.properties[spec].properties[template].properties[spec].properties[initContainers].x-kubernetes-list-map-keys: Invalid value: []string{"name"}: entries must all be names of item properties

 (reason: Invalid)

exit status 1

@dprotaso dprotaso mentioned this pull request Aug 13, 2024
Merged
@dprotaso
Copy link
Member

This should be unblocked by - #15467

then this PR needs to be regenerated

@knative-automation
upgrade to latest dependencies
4a7d2b5 
bumping golang.org/x/text 9c2f3a2...b2bec85:
  > b2bec85 go.mod: update golang.org/x dependencies
  > ae0cf96 LICENSE: update per Google Legal
bumping k8s.io/gengo f967bbe...a0386bf:
  > a0386bf Merge pull request # 267 from MadhavJivrajani/add-go-directive-verify
  > a8d1235 Merge pull request # 255 from TheSpiritXIII/parse-generics
  > 7d40e07 .*: add verify script for go directive changes
  > 9cff633 Merge pull request # 265 from longit644/master
  > 239d3d4 Support parsing type parameters
  > 51d4e06 Merge pull request # 262 from thockin/master
  > 2a31dd7 v2: Replace parallel arrays with array of objects in Signature.Parameters and Signature.Results
  > 00c4be8 Merge pull request # 261 from thockin/master
  > e4602e9 Drop go.mod version to 1.20
  > 471f57d Merge pull request # 259 from thockin/master
  > 1b5de37 Add 'ForTesting' to test-related function name
  > e7d5fc5 v2: Pass BuildTags in an Options struct
  > 3d3d421 Less impactful base-config injection
  > 483edb0 v2: s/Golang/Go/
  > bb7bd59 Allow tests to seed a packages.Config
  > 9d8f49d v2: verify script chdir to v2 root
  > f79cce5 Add a top-level 'make test' for v0 and v2
  > 008dc98 v2: Adapt PR 244 for v2
  > 780d761 v2: Only log it the first time a package is added
  > d43ccb5 v2: No need to check nil iterating Inputs
  > e246f57 v2: Rename SourcePath -> Dir
  > 4d1b815 v2: Rename Builder -> Parser
  > e08acb0 v2: Drop importPathString type
  > bb5d06d v2: Rename 'tc' import to 'gotypes'
  > d5e4a35 v2: Move utils from gengo/v2/types -> gengo/v2
  > 8679c27 v2: Remove now-unused FlattenMembers
  > 3446e13 v2: Get rid of the 'args' pkg
  > ccc4c0d v2: Get rid of CustomArgs entirely
  > b08ffa4 v2: Get rid of defaulter-gen (moved to k/k)
  > 8efa95a v2: Get rid of deepcopy-gen (moved to k/k)
  > 13c3e12 v2: Get rid of InputDirs flag - just use args
  > ea6ce31 v2: Drop test-files support
  > eb27a87 v2: Get rid of import-boss (moved to k/k)
  > f90bbd9 v2: Get rid of WithoutDefaultFlagParsing
  > c80e16a v2: Move go-header-file flag to each tool
  > e58ef8d v2: Remove verify-only - unused and untested
  > 292d08b v2: Move OutputFileBase flag to each tool
  > b02b6ab v2: Rename output-package -> output-pkg
  > 3d41cf4 v2: Make the OutputBase flag each tool's problem
  > 28180da v2: Type-assert CustomArgs blindly
  > be91502 v2: Rename DefaultGen -> GolangGenerator
  > 1d55203 v2: Rename Target.SourcePath() -> Dir()
  > 0f7c7f4 v2: Rename generator.Package -> Target
  > 08e97a3 v2: Drop `generator.Packages` type
  > 2a2caee v2: Rename DefaultPackage to SimplePackage
  > 97504d1 v2: Tighten the API to parser: args >> fields
  > 20e69f2 v2: Improve V(5) logging
  > 67e6f6a v2: Don't mkdir in verify mode
  > 5458972 v2: Use a type-switch in findTypesIn
  > c682af1 v2: Make comment handling easier to follow
  > 3d886b1 v2: Remove defunct trim-path-prefix
  > f06a6c1 v2: Remove unused functions
  > bb502ed v2: Deepcopy: Better logging
  > b291295 v2: Add a gengo/v2 README
  > a118b3d v2: Remove defunct references to "vendor"
  > 9b09b53 v2: Fix pointuh for v2
  > dceb5f1 v2: Fix kilroy for v2
  > 8cca9bb v2: Fix tracer for v2
  > ec9c476 v2: Fix import-boss for v2
  > d4d7c3c v2: Fix defaulter-gen for v2
  > 6064973 v2: Fix deepcopy-gen for v2
  > 7bd92cd v2: Use Go's packages.Load()
  > 92bda7a v2: Add trivial other-pkg example (pointuh)
  > 8e61ce4 v2: Add trivial same-package example (kilroy)
  > e06da46 v2: Add trivial gengo/v2 "tracer" example
  > f59fc19 v2: Remove set-gen: it's almost never used in k/k
  > b843a12 v2: Don't auto-set the Go header file
  > ce1e343 v2: Run and fix golangci-lint
  > 4c6a0f3 v2: Run gofmt on all Go files
  > 70d4955 v2: Bump golang.org/x/tools and mod tidy
  > 63cd203 v2: Change all imports to reference v2
  > 130553f Copy all code to v2, no changes
  > 6a789c9 Fix bad 'find' args in verify
bumping knative.dev/caching 0a5c1ed...93e6a0a:
  > 93e6a0a upgrade to latest dependencies (# 887)
  > dec3588 Update community files (# 886)
  > a1182ac upgrade to latest dependencies (# 885)
bumping k8s.io/kube-openapi 2dd684a...8e68654:
  > 8e68654 Merge pull request # 498 from kubernetes/dependabot/go_modules/github.com/onsi/ginkgo/v2-2.20.0
  > cc783e3 Merge pull request # 499 from kubernetes/dependabot/go_modules/test/integration/github.com/onsi/ginkgo/v2-2.20.0
  > 7c69d88 build(deps): bump github.com/onsi/ginkgo/v2 from 2.19.0 to 2.20.0
  > 7a9a4e8 Merge pull request # 494 from kubernetes/dependabot/go_modules/test/integration/github.com/onsi/gomega-1.34.1
  > ff86f7e build(deps): bump github.com/onsi/ginkgo/v2 in /test/integration
  > 6f6746f Merge pull request # 489 from lucacome/bump-deps
  > d9c5fbd build(deps): bump github.com/onsi/gomega in /test/integration
  > 3c01b74 Merge pull request # 483 from lucacome/fix-dependabot
  > a0f77d9 Bump all Go dependencies
  > 0aa61b4 Merge pull request # 481 from godwinpang/gpang-expose-builder-error
  > 104ce40 Use wildcard in dependabot config
  > b456828 Merge pull request # 480 from kubernetes/dependabot/github_actions/actions/setup-go-5
  > b3d76a1 go fmt
  > 2a08969 Merge pull request # 479 from kubernetes/dependabot/github_actions/actions/checkout-4
  > 713b93c build(deps): bump actions/setup-go from 4 to 5
  > 81c84df Bubble up buildOperations error.
  > e1a2242 Merge pull request # 474 from lucacome/add-dependabot
  > 84a746a build(deps): bump actions/checkout from 3 to 4
  > 835d969 Merge pull request # 469 from alexzielenski/nested-markers
  > 5d2ab2e Add dependabot
  > 31d65f7 Merge pull request # 464 from Jefftree/go-restful-version
  > 47d23e8 add context to error message for comment tags
  > 4a129a0 Merge pull request # 472 from lucacome/bump-ginkgo
  > 451ce29 Merge pull request # 475 from lucacome/bump-gziphandler
  > 36d11e3 bump go-restful to v3.11 to match k/k
  > 631461f Add support for adding validations for nested subschemas through marker comments
  > 8948a66 Merge pull request # 471 from devholic/fix-invalid-escape-sequence
  > ad44a3f Bump github.com/onsi/ginkgo/v2 to 2.17.2
  > f0e62f9 Merge pull request # 473 from lucacome/bump-gomega
  > a4f9fe0 Bump github.com/NYTimes/gziphandler to v1.1.1
  > 70dd376 Merge pull request # 462 from thockin/master
  > 2b4e2b0 bugfix: avoid non-deterministic output for extensions
  > dc4e619 Merge pull request # 465 from caozhuozi/fix/error-log
  > 5cb5474 refactor: use `Sprintf("%#v")` instead of `strconv.Quote`
  > 73400e3 Bump github.com/onsi/gomega to v1.33.1
  > 6eff651 Merge pull request # 460 from alexzielenski/nondeterminism
  > 8092cb0 Drop go.mod version to 1.20
  > bc84c2d Merge pull request # 467 from MadhavJivrajani/add-go-directive-verify
  > 7ad63e5 fix log level: error -> info
  > 23d5b2f fix: use `strconv.Quote` to generate description
  > f107216 Merge pull request # 459 from thockin/master
  > af4151f bugfix: resolve non-determinism in deduplicating enum comments
  > b815d83 Merge pull request # 466 from caozhuozi/doc/outdated
  > 9e8427a .*: add verify script for go directive changes
  > ee7ae60 Merge pull request # 458 from thockin/master
  > cfb2b85 xref already defaulted field vs. a literal
  > a74197f doc: the README.md under integration test is outdated
  > 582cce7 Merge pull request # 455 from alexzielenski/required-bugfix
  > 9f9049d Fix ./test/integration for gengo/v2
  > df3ca11 Use `path` instead of `filepath`
  > d73fd71 Merge pull request # 454 from alexzielenski/enum-list
  > 649db69 bugfix: avoid duplicate enum values
  > 571c24b Fix pkg/generators/openapi_test w/ packagestest
  > 2ac9dc5 Merge pull request # 448 from alexzielenski/required
  > 2c35350 bugfix: emit enum in schema when used as list or map element
  > b64ee37 bugfix: dont throw error if +required is set with omitempty
  > b9a9bc3 Run go get k8s.io/gengo/v2
  > 30be70b Merge pull request # 452 from alexzielenski/refactor-commenttags
  > f0e1bdd feature: add explicit +required
  > cb8c818 GolangGenerator -> GoGenerator
  > 37d671a Merge pull request # 453 from aurel32/master
  > eb740c5 refactor: make CommentTags internal
  > c91b59f Gengo utils moved
  > 7a0d5b4 Merge pull request # 447 from alexzielenski/cel-reason-fieldpath
  > b4a5507 test/integration: bump timeout to 20s
  > 66f3980 The gengo "args" package is gone
  > 2919ad4 Merge pull request # 446 from alexzielenski/cel-multiline
  > b0d00d4 feature: make cel marker comments aware of reason and field path
  > c6b9085 Get rid of gengo CustomArgs (gone in v2)
  > 2086090 Merge pull request # 445 from alexzielenski/cel-markers
  > f65ef9c test: add raw string with error test
  > f147b07 ParseSymbolReference is no longer exported
  > a37d4de Merge pull request # 444 from Schnides123/add-error-join
  > 85574cf feature: add parsing for CEL rules in comment tags
  > 0747b47 refactor: parse subscript with helper
  > 07de3d4 Get rid of InputDirs flag
  > a9f8850 Merge pull request # 443 from Jefftree/bump-gomod-121
  > 81a454b removed error-join shim after go version update
  > 41a30be bugfix: parsing array in comment tag resizing
  > 03b1d3a fixup tests after changes in errors and adding trimming to raw strings
  > ee2c702 Kill gengo WithoutDefaultFlagParsing (gone in v2)
  > 8a9faed Merge pull request # 440 from piperchester/patch-1
  > 2ac38b4 bump go to 121
  > fa5f665 bugfix: dont return child value when parsing arrays
  > 51616e8 bugfix: make lint array indices aware of other ops
  > 13a77a3 gengo/v2 moves go-header-file flag to each tool
  > bb40bc0 Merge pull request # 442 from kapouer/patch-1
  > 2ace7d5 Update README.md
  > 820afd5 bugfix: avoid panic when parsing subscripts
  > 41c4704 refactor: reuse compiled regex
  > 48882fa genego/v2 moves OutputFileBase flag to each tool
  > a58d4e6 Merge pull request # 441 from fazledyn-or/Fix_String_Matching_API
  > 69c5e06 Fix integration test route builder for go-restful > 3.8
  > ab13479 Merge pull request # 439 from ryantxu/add-v3-post-process
  > fca7b2a refactor: remove unused return value
  > ce262fb Rename output-package -> output-pkg (gengo/v2)
  > eec4567 Feature: Added support for OpenAPI validations marker comments (# 435)
  > 25ff75e Used a better API for string comparison
  > bf4651e Merge pull request # 438 from alexzielenski/zielenski-approver
  > 63d04c0 add v3 post process spec
  > 5fff8ab bugfix: emit CEL rule strings %#v
  > 39f9127 gengo/v2 moves the OutputBase flag to each tool
  > f0671cc Merge pull request # 312 from deads2k/allow-empty-discriminator
  > aa524b5 add alexzielenski to OWNERS
  > 90b8d5f add raw string syntax to marker comments
  > 4946e68 Type-assert gengo CustomArgs blindly
  > 778a556 Merge pull request # 437 from thockin/master
  > 78a2dba Allow union without any fields-to-discriminateBy
  > 4079daf Rename gengo/v2 DefaultGen -> GolangGenerator
  > 34ea5aa Do not require listType on []byte fields
  > 007cebb Rename `gengo/v2/generator.Package` -> `Target`
  > f82efc8 Drop `gengo/v2/generator.Packages` type
  > 5fef66a Rename DefaultPackage to SimplePackage (gengo/v2)
  > a5de500 Fix kube-openapi wrt gengo/v2
  > ab79d75 Don't auto-set the Go header file flag
  > bdea997 Convert imports to gengo/v2
  > ffcc404 Use our own sets pkg instead of gengo
  > d1213fd Commit latest integration results
bumping knative.dev/hack 441a19f...452e340:
  > 452e340 Update community files (# 392)
bumping google.golang.org/genproto/googleapis/rpc 5315273...573a115:
  > 573a115 chore(all): auto-regenerate .pb.go files (# 1144)
  > 2c9e96a chore(all): update all (# 1149)
  > b1a4ccb chore(all): update all (# 1148)
  > 93522f1 chore: rev bigtable to unreleased commit (# 1147)
  > 90e4760 feat: move bigtable protos to google-cloud-go (# 1146)
  > e6d459c chore(all): update all (# 1142)
  > d784300 chore(all): auto-regenerate .pb.go files (# 1143)
  > 46eb208 chore(all): auto-regenerate .pb.go files (# 1141)
  > 40e1e62 chore(all): auto-regenerate .pb.go files (# 1140)
  > 4ad9e85 chore(all): auto-regenerate .pb.go files (# 1139)
  > 654c5fe chore(all): update all (# 1138)
  > f6361c8 chore(all): update all (# 1137)
  > dc46fd2 chore(all): update all (# 1135)
  > 68d350f chore(all): update all (# 1134)
  > a8a6208 chore(all): update all (# 1133)
  > ef581f9 chore(all): update all (# 1132)
bumping knative.dev/networking f170238...d4c57cd:
  > d4c57cd Update community files (# 999)
  > fb56e09 upgrade to latest dependencies (# 998)
bumping golang.org/x/term c976cb1...d598954:
  > d598954 go.mod: update golang.org/x dependencies
  > d4346f0 LICENSE: update per Google Legal
bumping golang.org/x/time 883aed5...5d9ef58:
  > 5d9ef58 LICENSE: update per Google Legal
bumping k8s.io/utils e7106e6...18e509b:
  > 18e509b Merge pull request # 314 from thockin/pr-311-plus-thockin
  > d4aae2b Merge pull request # 311 from aroradaman/net-multi-listen
  > a1afdb7 Add multi-listener test for HTTP
  > fe8a2dd Merge pull request # 302 from logicalhan/set-tests
  > 27da63f net: add multi listener impl for net.Listener
  > 0849a56 Merge pull request # 301 from dgrisonnet/traces-verbosity
  > 8c89a86 add test coverage to set.go
  > 4693a02 Merge pull request # 306 from MadhavJivrajani/check-for-go-directive-bump
  > be5eaf9 trace: gate traces behind log level 2
  > b01eb69 .*: add presubmit check for verifying go directive changes
bumping github.com/go-openapi/swag b3e7a53...53e32e8:
  > 53e32e8 chore(go): go-openapi requires go.1.20 across the board
  > 5e655d8 fix(ci): remove dependency-type from dependabot groups
  > 54f3f80 chore(lint): relinted
  > 4896833 Bump github.com/stretchr/testify from 1.8.4 to 1.9.0
  > 6b32215 Bump the development-dependencies group with 1 update
  > db91acc ci: remove paths-ignores
  > fec0b4e Bump the development-dependencies group with 1 update
  > 14fcae4 chore(ci): prevents duplicate workflow runs
  > d33767c Bump the development-dependencies group with 1 update
  > c877230 ci(dependencies): automate dependencies updates
  > a05020e Bump actions/setup-go from 4 to 5
  > 8ce930b Bump actions/checkout from 3 to 4
  > 76c9b7c Updated dependabot frequency to monthly
  > e181373 Added dependabot
  > 216b00a refreshed go.mod
  > 01194a0 perf(mangling): optimized the processing of initialisms

Signed-off-by: Knative Automation <[email protected]>
@dprotaso
Copy link
Member

/override "style / Golang / Lint"

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 14, 2024

@dprotaso: Overrode contexts on behalf of dprotaso: style / Golang / Lint

In response to this:

/override "style / Golang / Lint"

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-automation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2024
@knative-prow knative-prow bot merged commit 446e690 into knative:main Aug 14, 2024
67 of 68 checks passed
@cardil cardil mentioned this pull request Aug 28, 2024
Closed
@SaschaSchwarze0 SaschaSchwarze0 mentioned this pull request Nov 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knative-automation @dprotaso