Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kube-codegen.sh instead of generate-groups.sh when moving to k8s.io api 0.28+ #336

Closed
andrew-su opened this issue Oct 12, 2023 · 5 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@andrew-su
Copy link
Member

As of k8s.io/[email protected], the script generate-groups.sh is deprecated and we should move to using kube-codegen.sh

@andrew-su
Copy link
Member Author

Related: #335

@cardil
Copy link
Contributor

cardil commented Aug 28, 2024

The Kube v0.30 removed the generate-groups.sh contents, which in turn renders Knative code-generation broken.

Knative already rolled to Kube v0.30, for example: knative/serving#15462, knative/eventing#8126, so this essentailly prevents changes to any Knative CRDs.

As discussed in the Productivity WG, I will create a generate-groups like tool in Knative ASAP, and notify Knative working groups on migration steps in all the Knative projects, that use code-gen.

/assign
/kind bug

@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 28, 2024
@matzew
Copy link
Member

matzew commented Aug 28, 2024

Thanks a lot, @cardil

@cardil
Copy link
Contributor

cardil commented Sep 2, 2024

Some maintainers already started doing the migration to kube_codegen.sh script:

And because it looks like it shouldn't be super hard, we decided it makes sense to just go with it, so the interim generate-groups.sh shim (that I proposed on Productivity WG) wouldn't be required.

We created the doc to track the migration effort: https://docs.google.com/spreadsheets/d/12OG7kLYlJIz-vOKihdtG1Vtrg0OsD8vF_umJLFK0_kQ

/close

Copy link

knative-prow bot commented Sep 2, 2024

@cardil: Closing this issue.

In response to this:

Some maintainers already started doing the migration to kube_codegen.sh script:

And because it looks like it shouldn't be super hard, we decided it makes sense to just go with it, so the interim generate-groups.sh shim (that I proposed on Productivity WG) wouldn't be required.

We created the doc to track the migration effort: https://docs.google.com/spreadsheets/d/12OG7kLYlJIz-vOKihdtG1Vtrg0OsD8vF_umJLFK0_kQ

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants