Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add promise handling to isIdentified() call #284

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Add promise handling to isIdentified() call #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdb0cbd
updates isIdentified to correctly handle promise
cykolln Jan 18, 2024
faf3573
updates changelog
cykolln Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
<!-- BEGIN RELEASE NOTES -->
### [Unreleased]

#### Fixed
- Updated customer.js to correctly handle promise returned from isIdentified

### [4.1.1] - 2023-12-12

#### Added
Expand Down
17 changes: 10 additions & 7 deletions view/frontend/web/js/customer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,16 @@ define([
customerData.getInitCustomerData().done(function () {
var customer = customerData.get('customer')();

if(_.has(customer, 'email') && customer.email && !klaviyo.isIdentified()) {
klaviyo.identify({
'$email': customer.email,
'$first_name': _.has(customer, 'firstname') ? customer.firstname : '',
'$last_name': _.has(customer, 'lastname') ? customer.lastname : ''
});
}
klaviyo.isIdentified().then((identified)=> {
if(_.has(customer, 'email') && customer.email && !identified) {
klaviyo.identify({
'$email': customer.email,
'$first_name': _.has(customer, 'firstname') ? customer.firstname : '',
'$last_name': _.has(customer, 'lastname') ? customer.lastname : ''
});
}
});

});

});