Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add promise handling to isIdentified() call #284

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Add promise handling to isIdentified() call #284

merged 2 commits into from
Jan 18, 2024

Conversation

cykolln
Copy link
Contributor

@cykolln cykolln commented Jan 18, 2024 •
edited
Loading

Description

Fixes a bug where we don't correctly handle the Promise returned by klaviyo.isIdentified(). Was preventing us from identifying customers after account registration or login.

Manual Testing Steps

  1. Tested that I'm correctly identified in Klaviyo after registering a new account
  2. Tested that I'm correctly identified in Klaviyo after logging into an account.

Pre-Submission Checklist:

  • You've updated the CHANGELOG following the steps here
  • Internal Only - If this is a release, please confirm the following:
    • The links in the changelog have been updated to point towards the new versions
    • The version has been incremented in the following places: module.xml and composer.json

NOTE: Please use the Changelogger cli tool to manage versioned file upgrades.

@cykolln cykolln requested a review from a team as a code owner January 18, 2024 00:29
jordanleslie
jordanleslie approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@jordanleslie jordanleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the test plan to catch this!

smoucka
smoucka approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@smoucka smoucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@cykolln
Copy link
Contributor Author

cykolln commented Jan 18, 2024

Fixes #283

@cykolln cykolln merged commit 8b3ed62 into master Jan 18, 2024
3 checks passed
@cykolln cykolln deleted the 202401_ECOS-3570_add_promise_handling branch January 18, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordanleslie jordanleslie jordanleslie approved these changes

@smoucka smoucka smoucka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cykolln @smoucka @jordanleslie