-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Apple Platforms #638
Conversation
As far as I can tell, the |
@mgautierfr Can you please have a look? |
Haven't had a close look, but it missing at least a change in the build definition (That's why https://github.com/kiwix/kiwix-build/actions/runs/6575114946/job/17861547005?pr=638)
|
This PR also show a usage of c++ feature deprecated in c++17 in zim-tools. |
I'm not in favour to abandon support of macOS11 for libzim without clear reason. Libzim bindings should better stay compatible with older versions of macOS as long as it does not create serious problems. Having a ticket explaining why we do things would be helpful. PR without corresponding issues should be avoided or kept for very trivial changes. |
@@ -15,49 +15,48 @@ | |||
# 'D' letter means we trigger the docker forkflow to build the docker image. | |||
# If a cell contains several letters, all are done. | |||
BUILD_DEF = """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⬇️ use hide whitespace on GitHub to see what's changed
| macos | iOS_simulator_x86 | B | B | | | | | | ||
| macos | iOS_simulator_arm64 | B | B | | | | | | ||
| macos | macOS_arm64 | B | B | | | | macos-arm64 | | ||
| macos | macOS_x86 | B | B | | | | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I don't think I fully understand what the differences are between B
, dB
and BP
(yes I did read the keys)
Obviously I am coming from a kiwix for macOS and iOS perspective, so correct me if something should be changed
@kelson42 Hey, are there anyone else that needs libzim on macOS 11? If I (i.e. kiwix for macOS and iOS app) is the only one, then that might be a good reason to no longer support macOS 11, since the kiwix app does not support macOS 11. |
We are in https://github.com/openzim/python-libzim |
@automactic @mgautierfr @rgaudin We are in an almost emergency situation to move forward on Apple custom apps. This is TOP PRIO that we CI+CD for libzim and libkiwix for both macOS and iOS work ASAP. Therefore this PR should be on the very TOP of the agenda. |
After discussion with @rgaudin regarding the min macOS version, we agreed:
I will update the CI/CD. |
Probably superseeded by #650. |
Superseeded by #653 |
mmacosx-version-min
andmmacosx-version-min
in various places