Build zim-tools and kiwix-tools on macos-arm64 #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgautierfr
force-pushed
the
tools_on_macos_m1
branch
from
78919fa to
23f3183
Compare
|
@rgaudin Can you try https://tmp.kiwix.org/ci/dev_preview/tools_on_macos_m1/kiwix-tools_macos-arm64-2023-11-07.tar.gz and https://tmp.kiwix.org/ci/dev_preview/tools_on_macos_m1/zim-tools_macos-arm64-2023-11-07.tar.gz ? This PR removes the |
|
Both work fine (tested kiwix-serve and zimcheck) 👍 Indeed, as explained, we want to remove bitcode from now |
mgautierfr
force-pushed
the
tools_on_macos_m1
branch
from
23f3183 to
2ed27f2
Compare
mgautierfr
force-pushed
the
tools_on_macos_m1
branch
from
2ed27f2 to
5b22821
Compare
|
Rebased on #638 to use the changes made there. |
mgautierfr
changed the title
|
@mgautierfr Is that ready to review by @rgaudin? |
It is, but the PR is really simple, most of the job has been made in #638. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #593
Fix #592