Remove -Werror. #1085
Remove -Werror. #1085
Conversation
|
@veloman-yunkan @mgautierfr Is that a good idea to relax here? Actually I have asking yesterday in an other ticket to implement |
In absolute terms, not. But without at least an error message telling us what's wrong it would be difficult to fix the warning. In the meanwhile kiwix-desktop is not compiling on Windows and we cannot publish nightly or release. Maybe good to keep a issue open about that but for now I think the priority is to keep kiwix-desktop building on Windows. |
| @@ -18,7 +18,7 @@ greaterThan(QT_MAJOR_VERSION, 4): QT += widgets | |||
| TARGET = kiwix-desktop | |||
| TEMPLATE = app | |||
|
|
|||
| QMAKE_CXXFLAGS += -std=c++17 -Werror | |||
| QMAKE_CXXFLAGS += -std=c++17 | |||
There was a problem hiding this comment.
Can't we disable -Werror only under Windows?
There was a problem hiding this comment.
We have a general problem that Windows compiler options are not the same as gcc. We have a similar situation with the cpp17 option.
There was a problem hiding this comment.
@kelson42 it is not clear to me what the issue is. Can we not do something like the below?
!win32 {
QMAKE_CXXFLAGS += -Werror
}
There was a problem hiding this comment.
Done.
Successful build with last change is https://ci.appveyor.com/project/Kiwix/kiwix-build/builds/49615228
I have open #1087 |
`-Werror` make compilation fails on Windows.
-Werrormake compilation fails on Windows.The exact warning making the compilation failing is not clear.
See (https://ci.appveyor.com/project/Kiwix/kiwix-build/builds/49600994 for example).
Compilation without
-Werroris ok (https://ci.appveyor.com/project/Kiwix/kiwix-build/builds/49601697)Fix kiwix/kiwix-build#690