Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile without warnings #1087

Closed
kelson42 opened this issue Apr 13, 2024 · 7 comments
Closed

Compile without warnings #1087

kelson42 opened this issue Apr 13, 2024 · 7 comments
Assignees
Labels
Milestone

Comments

@kelson42
Copy link
Collaborator

Kiwix should be able to compile without warnings. Once achieved we should put proper compiler options to report any warning in error.

@kelson42 kelson42 added the task label Apr 13, 2024
@kelson42 kelson42 added this to the 2.5.0 milestone Apr 13, 2024
@kelson42 kelson42 moved this to TODO in GSOC 2024 May 3, 2024
@kelson42
Copy link
Collaborator Author

@ShaopengLin until PR review moves forward, can you move on this issue?

@ShaopengLin
Copy link
Collaborator

ShaopengLin commented May 29, 2024

@kelson42 I am having a hard time getting the build system working on Windows. Is there any documented step on it?

@kelson42
Copy link
Collaborator Author

@ShaopengLin Yes, not easy and this even changing currently. Please tackle the provlem on linux first.

@ShaopengLin
Copy link
Collaborator

@kelson42 Maybe I missed some details, but we are already treating warnings as errors in Linux. #1085 seems to be a Windows-specific problem.

@kelson42 kelson42 moved this from TODO to DOING in GSOC 2024 May 30, 2024
@kelson42
Copy link
Collaborator Author

I will check again but as I have open the issue, the compilation had warning on Linux so the acI was not failing because of this.

@ShaopengLin
Copy link
Collaborator

Any updates? I cannot observe any warnings other than on Qt 5.12.8, where the warnings are rather, from Qt source code.

@kelson42
Copy link
Collaborator Author

Ok, then closing for the moment and will reopen when Insee a warning in the CI.

@kelson42 kelson42 closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2024
@github-project-automation github-project-automation bot moved this from DOING to DONE in GSOC 2024 May 31, 2024
@kelson42 kelson42 modified the milestones: 2.5.0, 2.4.0 May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: DONE
Development

No branches or pull requests

2 participants