Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -Werror. #1085

Merged
merged 1 commit into from
Apr 15, 2024
+5 −1
Merged

Remove -Werror. #1085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion kiwix-desktop.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,13 @@ greaterThan(QT_MAJOR_VERSION, 4): QT += widgets
TARGET = kiwix-desktop
TEMPLATE = app

QMAKE_CXXFLAGS += -std=c++17 -Werror
QMAKE_CXXFLAGS += -std=c++17
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we disable -Werror only under Windows?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a general problem that Windows compiler options are not the same as gcc. We have a similar situation with the cpp17 option.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kelson42 it is not clear to me what the issue is. Can we not do something like the below?

!win32 {
    QMAKE_CXXFLAGS += -Werror
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Successful build with last change is https://ci.appveyor.com/project/Kiwix/kiwix-build/builds/49615228

QMAKE_LFLAGS += -std=c++17

!win32 {
QMAKE_CXXFLAGS += -Werror
}

# Also change resources/org.kiwix.desktop.appdata.xml
DEFINES += VERSION="2.3.1"

Expand Down
Loading