-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ESP-IDF only for WiFi #253
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lptr
force-pushed
the
use-esp-idf-wifi
branch
from
December 1, 2024 17:08
9dcd797
to
e542631
Compare
lptr
force-pushed
the
use-esp-idf-wifi
branch
from
December 1, 2024 18:08
fd720c5
to
425d138
Compare
lptr
force-pushed
the
use-esp-idf-wifi
branch
from
December 1, 2024 18:08
425d138
to
74a72db
Compare
This was referenced Dec 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major refactor, and a big step towards dropping Arduino completely.
Fixes #224.
Changes
MQTTPubSubClient
,NTPClient
and their dependencies for built-in functions.ESP_LOGX()
macros. This way logging is significantly simpler, and we get to handle all the system notifications as well in a uniform way (including reporting them over MQTT).One thing that got significantly better with the rewrite is MQTT connections: they happen much faster, and the device is much more responsive. I guess this is because we don't rely on a poll-based mechanism anymore. Yay! 🎉
Most importantly this fixes the memory leak with repeated WiFi reconnections -- see #224. \o/
Known issues