Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging fixes #258

Merged
merged 12 commits into from
Dec 5, 2024
Merged

Logging fixes #258

merged 12 commits into from
Dec 5, 2024

Conversation

lptr
Copy link
Member

@lptr lptr commented Dec 4, 2024

Fix problems that occurred after

Fixes #257

  • They appear out-of-order
  • They are have newlines at the end
  • The cut-off at 128 characters is too short for some messages
  • They all appear to be reported as [Warning]

@lptr lptr added the bug Something isn't working label Dec 4, 2024
@lptr lptr self-assigned this Dec 4, 2024
@lptr
Copy link
Member Author

lptr commented Dec 4, 2024

So the out-of-order thing is the most annoying obviously, but it might also be responsible for the quick boot time we now see (takes about 2 seconds for cud to boot instead of the usual 6-7 seconds).

Currently the client sends logs with QoS 1, but even if I switch to QoS 2, the message order isn't getting better.

@lptr
Copy link
Member Author

lptr commented Dec 4, 2024

Even if I put a 5-second timeout on publishing log messages, which should make the publishing wait for each message being published before the next one is processed, does not seem to have an effect. Weird, especially that it worked perfectly in-order with MQTTPubSubClient before... 🤔

@lptr lptr merged commit 19b9030 into main Dec 5, 2024
7 checks passed
@lptr lptr deleted the logging/fixes branch December 5, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with logs sent to server
1 participant