Add matrix CI using Github Actions #353
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| name: build | ||
|
|
||
| on: [push] | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest, windows-latest, macOS-latest] | ||
| rust: [stable, nightly] | ||
|
|
||
| steps: | ||
| - uses: hecrj/setup-rust-action@v1 | ||
|
There was a problem hiding this comment. what does There was a problem hiding this comment. Mostly simplifies the install of the rustc version & components with with:
rust-version: stable
components: clippy |
||
| with: | ||
| rust-version: ${{ matrix.rust }} | ||
| components: rustfmt, clippy | ||
|
There was a problem hiding this comment. please remove the components here and move clippy to a separate job as well There was a problem hiding this comment. Yep. Wondering if a separate check task is necessary as clippy does run check (https://stackoverflow.com/questions/57449356/is-cargo-clippy-a-superset-of-cargo-check) |
||
| - uses: actions/checkout@master | ||
| - name: Build | ||
| run: cargo build --verbose | ||
| - name: Run tests | ||
| run: cargo test --verbose | ||
|
|
||
| check: | ||
| name: check (ubuntu-latest, stable) | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: hecrj/setup-rust-action@v1 | ||
| with: | ||
| rust-version: stable | ||
| - name: Checkout sources | ||
| uses: actions/checkout@v1 | ||
| - name: Cargo Check | ||
| run: cargo check | ||
|
|
||
| clippy: | ||
| name: clippy (ubuntu-latest, stable) | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: hecrj/setup-rust-action@v1 | ||
| with: | ||
| rust-version: stable | ||
| components: clippy | ||
| - name: Checkout sources | ||
| uses: actions/checkout@v1 | ||
| - name: Cargo Clippy | ||
| run: cargo clippy -- -D warnings -A deprecated | ||
|
|
||
| fmt: | ||
| name: fmt (ubuntu-latest, stable) | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: hecrj/setup-rust-action@v1 | ||
| with: | ||
| rust-version: stable | ||
| components: rustfmt | ||
| - name: Checkout sources | ||
| uses: actions/checkout@v1 | ||
| - name: Check Formatting | ||
| run: cargo fmt --all -- --check | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,10 @@ | ||
| status = [ | ||
| "build (ubuntu-latest, stable)", | ||
| "build (ubuntu-latest, nightly)", | ||
| "build (windows-latest, stable)", | ||
| "build (windows-latest, nightly)", | ||
| "build (macOS-latest, stable)", | ||
| "build (macOS-latest, nightly)", | ||
| "continuous-integration/travis-ci/push", | ||
| ] | ||
| use_squash_merge = true |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about running nightly on all platforms, ubuntu should be enough, also we should allow it to fail