-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add matrix CI using Github Actions #353
Conversation
GitHub Actions CI is configured but build is failing on nightly because of 1 failing test on upgrade_as_expected with error (same as with Travis CI): ---- upgrade_as_expected stdout ----
Status code: ExitStatus(ExitStatus(256))
STDOUT: Updating 'https://github.com/rust-lang/crates.io-index' index
STDERR: Command failed due to unhandled error: Invalid manifest
Caused by: Error during execution of `cargo metadata`: error: failed to parse manifest at `/var/folders/r9/fy7r7w3x511gl63wd9pt3l980000gn/T/cargo-edit-test.mMTENrSLyuWA/Cargo.toml`
Caused by:
failed to parse `x86_64/windows.json` as a cfg expression: invalid target specifier: unexpected character / in target name |
dd14195
to
b5777c1
Compare
Gothub Action tests on Windows anyway.
Thanks! Let's see how this goes! bors r+ |
.github/workflows/build.yml
Outdated
- uses: hecrj/setup-rust-action@v1 | ||
with: | ||
rust-version: ${{ matrix.rust }} | ||
components: rustfmt, clippy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the components here and move clippy to a separate job as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Wondering if a separate check task is necessary as clippy does run check (https://stackoverflow.com/questions/57449356/is-cargo-clippy-a-superset-of-cargo-check)
rust: [stable, nightly] | ||
|
||
steps: | ||
- uses: hecrj/setup-rust-action@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does hecrj/setup-rust-action
provide compared to action-rs/toolchain
?
also, it would be nice to use cache, see https://github.com/iqlusioninc/crates/blob/develop/.github/workflows/rust.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly simplifies the install of the rustc version & components with
with:
rust-version: stable
components: clippy
.github/workflows/build.yml
Outdated
strategy: | ||
matrix: | ||
os: [ubuntu-latest, windows-latest, macOS-latest] | ||
rust: [stable, nightly] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about running nightly on all platforms, ubuntu should be enough, also we should allow it to fail
…tu, and continue on error
resolve #352