-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark theme support #159
Dark theme support #159
Conversation
Some yet-to-dos:
|
Regarding todo no. 2, I think there is also a preference in the klighd view that enforces a white background, in this case it woun't make much sense to activate/send color preferences for a dark theme, or do you mean this by no. 2? |
Haven't thought it through yet, but I would like to make this more automatic and consistent. For this example, if a white background is enforced, then sending no color preferences could be a good idea to allow to show the synthesis-default color theme with this option and to use the theme only in the other cases. |
…een modes missing yet.
These options work. I need them. So they finally get reactivated!
…pment (watch), use the correct ones to make webview and extension debuggable.
Improve production/development minimization/debuggability
…in focus During adoption to Sprotty 0.13 another way of updating the diagram was introduced that always requests a diagram when the editor is switched. When opening VS Code now with no editor in focus (e.g. when the diagram was in focus, which is not re-opened by VS Code by default), clicking on an editor triggered this newly introduced switch AND this now-removed code we had for exactly that use case. As this is now superfluous and causes duplicated requests, this removes that issue.
implement client-only layout.
update json schema
Create build-types.yml action to test whether modified schema file can generate pydantic types correctly
fixed flex layout in chrome for option checkboxes
This PR might need to be closed and re-opened, GitHub falsely indicates most changes from the main branch to be part of this PR as well, although the branches differ only by a few changes. |
…theme type and colors (hardcoded) of VS Code, concrete colors also on theme change (VS Code). Removes ForceLightBackground option
This PR shows 61 changed files, although there are only 9, closing and re-opening this one. |
Implements support for dark / other color themes for clients over the LSP and adds a property to be read by syntheses to conform to some theme-related foreground/background/highlighting colors.
Relates to kieler/KLighD#175