Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme support #159

Closed
wants to merge 29 commits into from
Closed

Dark theme support #159

wants to merge 29 commits into from

Conversation

NiklasRentzCAU
Copy link
Member

Implements support for dark / other color themes for clients over the LSP and adds a property to be read by syntheses to conform to some theme-related foreground/background/highlighting colors.

Relates to kieler/KLighD#175

@NiklasRentzCAU NiklasRentzCAU added the enhancement New feature or request label Oct 18, 2023
@NiklasRentzCAU
Copy link
Member Author

NiklasRentzCAU commented Oct 18, 2023

Some yet-to-dos:

  • let the CLI default light theme color be null to allow for an unaffected synthesis to render its default light theme colors and set own defaults
  • automatically set the background to light/dark depending on the synthesis
  • set the background color to some dark color for the CLI if the system suggests that, so that dark mode synthesis also appear on a dark background per default.
  • make sure that a release with this update in klighd-vscode won't break existing servers that did not update to a new KLighD release yet. I.e. the newly sent messages would crash an old server currently as they are not supported. Maybe some way to send the KLighD protocol version at initialization and only use features/messages if the server version is high enough

@a-sr
Copy link
Member

a-sr commented Oct 18, 2023

Regarding todo no. 2, I think there is also a preference in the klighd view that enforces a white background, in this case it woun't make much sense to activate/send color preferences for a dark theme, or do you mean this by no. 2?

@NiklasRentzCAU
Copy link
Member Author

Regarding todo no. 2, I think there is also a preference in the klighd view that enforces a white background, in this case it woun't make much sense to activate/send color preferences for a dark theme, or do you mean this by no. 2?

Haven't thought it through yet, but I would like to make this more automatic and consistent. For this example, if a white background is enforced, then sending no color preferences could be a good idea to allow to show the synthesis-default color theme with this option and to use the theme only in the other cases.

NiklasRentzCAU and others added 24 commits September 28, 2024 21:34
These options work. I need them. So they finally get reactivated!
…pment (watch), use the correct ones to make webview and extension debuggable.
Improve production/development minimization/debuggability
…in focus

During adoption to Sprotty 0.13 another way of updating the diagram was introduced that always requests a diagram when the editor is switched. When opening VS Code now with no editor in focus (e.g. when the diagram was in focus, which is not re-opened by VS Code by default), clicking on an editor triggered this newly introduced switch AND this now-removed code we had for exactly that use case. As this is now superfluous and causes duplicated requests, this removes that issue.
Create build-types.yml action to test whether modified schema file can generate pydantic types correctly
@NiklasRentzCAU
Copy link
Member Author

This PR might need to be closed and re-opened, GitHub falsely indicates most changes from the main branch to be part of this PR as well, although the branches differ only by a few changes.

…theme type and colors (hardcoded) of VS Code, concrete colors also on theme change (VS Code). Removes ForceLightBackground option
@NiklasRentzCAU
Copy link
Member Author

This PR shows 61 changed files, although there are only 9, closing and re-opening this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants