Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme support #210

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Dark theme support #210

wants to merge 4 commits into from

Conversation

NiklasRentzCAU
Copy link
Member

Implements support for dark / other color themes for clients over the LSP and adds a property to be read by syntheses to conform to some theme-related foreground/background/highlighting colors.

Relates to kieler/KLighD#175
Succeeds #159

@NiklasRentzCAU
Copy link
Member Author

@a-sr You may test these changes now with your semantics branch and SCCharts, the changes I wanted are now all included in this PR.

A few things that are not yet 100%, but good enough for this feature to roll onto the master, are the following:

  • old servers will throw an exception on the console on theme change in VS Code. This is only aesthetic and does not change the behavior and does not cause the server to crash, so this is fine.
  • during initialize, VS Code does not send the current theme colors, but hard-coded colors (currently matching the default VS Code light/dark themes), because VS Code does not offer any API to get the colors of the current theme on the extension side. The real theme colors are only sent on theme change in VS Code, where I can look into the document and find the corresponding CSS styles to get the real colors (feels a little hacky)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant